Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 16, 2020

we don't need to load every last plex font variant

Fixes #3831

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #4312 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4312      +/-   ##
==========================================
+ Coverage   59.44%   59.45%   +0.01%     
==========================================
  Files          74       74              
  Lines        2399     2400       +1     
  Branches      582      583       +1     
==========================================
+ Hits         1426     1427       +1     
- Misses        744      746       +2     
+ Partials      229      227       -2     
Impacted Files Coverage Δ
packages/core/src/webapp/themes/persistence.ts 77.41% <100.00%> (+0.37%) ⬆️
packages/core/src/core/command-tree.ts 69.13% <0.00%> (-0.87%) ⬇️
packages/core/src/util/i18n.ts 64.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d8895...6017115. Read the comment docs.

@starpit starpit force-pushed the fonts branch 3 times, most recently from b6e1522 to 8b5a42d Compare April 17, 2020 13:21
we don't need to load every last plex font variant

Fixes kubernetes-retired#3831
@starpit starpit merged commit aa833b1 into kubernetes-retired:master Apr 17, 2020
@starpit starpit deleted the fonts branch April 17, 2020 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reduce load time of plex fonts

1 participant