Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 21, 2020

Fixes #4345

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #4346 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4346      +/-   ##
==========================================
- Coverage   59.50%   59.41%   -0.09%     
==========================================
  Files          74       74              
  Lines        2400     2400              
  Branches      583      583              
==========================================
- Hits         1428     1426       -2     
- Misses        743      747       +4     
+ Partials      229      227       -2     
Impacted Files Coverage Δ
packages/core/src/core/command-tree.ts 69.56% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebba36e...7caab21. Read the comment docs.

@starpit starpit merged commit 639ca32 into kubernetes-retired:master Apr 21, 2020
@starpit starpit deleted the fix-4345 branch April 21, 2020 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve odo usage experience

1 participant