Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 25, 2020

Fixes #4368

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #4369 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4369      +/-   ##
==========================================
- Coverage   58.89%   58.81%   -0.09%     
==========================================
  Files          75       75              
  Lines        2411     2411              
  Branches      582      582              
==========================================
- Hits         1420     1418       -2     
- Misses        763      767       +4     
+ Partials      228      226       -2     
Impacted Files Coverage Δ
packages/core/src/core/command-tree.ts 69.56% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516b976...a4ae615. Read the comment docs.

@starpit starpit force-pushed the prompt branch 2 times, most recently from 7e3062f to eb3da93 Compare April 25, 2020 20:56
@starpit starpit merged commit 75a3efe into kubernetes-retired:master Apr 25, 2020
@starpit starpit deleted the prompt branch April 25, 2020 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

on linux (and macos 10.14?) > part of prompt is misaligned

1 participant