Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 25, 2020

… when sidecar is maximized

Fixes #4374

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #4375 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4375      +/-   ##
==========================================
+ Coverage   58.89%   59.02%   +0.12%     
==========================================
  Files          75       75              
  Lines        2411     2411              
  Branches      582      582              
==========================================
+ Hits         1420     1423       +3     
+ Misses        763      760       -3     
  Partials      228      228              
Impacted Files Coverage Δ
packages/core/src/core/userdata.ts 68.05% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516b976...93bf220. Read the comment docs.

@starpit starpit merged commit bbf7ecd into kubernetes-retired:master Apr 25, 2020
@starpit starpit deleted the fix-4374 branch April 25, 2020 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when maximizing sidecar, "window buttons" shift over by a few pixels

1 participant