Change comments

Author: Alan-Cha

packages/openapi-to-graphql/lib/index.js

@@ -107,7 +107,8 @@ export declare type Operation = {
      */
     inViewer: boolean;
     /**
-     * Type of operation
+     * Type of root operation type, i.e. whether the generated field should be
+     * added to the Query, Mutation, or Subscription root operation
      */
     operationType: GraphQLOperationType;
     /**

packages/openapi-to-graphql/lib/index.js.map

@@ -43,7 +43,7 @@
     "api_sub": "nodemon test/example_api5_server.js",
     "dev": "tsc -w",
     "start_dev": "DEBUG=preprocessing,translation,http nodemon test/example_gql_server.js",
-    "start_dev_sub": "DEBUG=preprocessing,translation,http,pubsub nodemon test/example_gql_server_ws.js",
+    "start_dev_ws": "DEBUG=preprocessing,translation,http,pubsub nodemon test/example_gql_server_ws.js",
     "build": "tsc",
     "guru-load": "node test/evaluation/load_apis_guru.js",
     "guru-test": "DEBUG=preprocessing,translation node test/evaluation/eval_apis_guru.js",

packages/openapi-to-graphql/lib/resolver_builder.js

@@ -764,9 +764,6 @@ export function getResolver({
                   saneData = arraySaneData
                 }
 
-                // if (operation.callbacks)
-                // pubsub.publish(``, saneData) ?
-
                 resolve(saneData)
               } else {
                 // TODO: Handle YAML
@@ -989,9 +986,10 @@ function getAuthReqAndProtcolName(
 }
 
 /**
- * Given a link parameter | callback path, determine the value
+ * Given a link parameter or callback path, determine the value from the runtime
+ * expression
  *
- * The link parameter | callback path is a reference to data contained in the
+ * The link parameter or callback path is a reference to data contained in the
  * url/method/statuscode or response/request body/query/path/header
  */
 function resolveRuntimeExpression(

packages/openapi-to-graphql/lib/resolver_builder.js.map

@@ -244,7 +244,6 @@ type ComponentsObject = {
   callbacks?: {
     [key: string]: CallbackObject | ReferenceObject
   }
-  // callbacks?: CallbacksObject
 }
 
 type TagObject = {

packages/openapi-to-graphql/lib/types/operation.d.ts

@@ -171,7 +171,8 @@ export type Operation = {
   inViewer: boolean
 
   /**
-   * Type of operation
+   * Type of root operation type, i.e. whether the generated field should be
+   * added to the Query, Mutation, or Subscription root operation
    */
   operationType: GraphQLOperationType
 

packages/openapi-to-graphql/package.json

@@ -21,7 +21,7 @@ const HTTP_PORT = 3008
 const MQTT_PORT = 1885
 
 oas.servers[0].variables.port.default = String(HTTP_PORT)
-// oas.servers[1].variables.port.default = String(MQTT_PORT)
+oas.servers[1].variables.port.default = String(MQTT_PORT)
 
 let createdSchema
 let wsServer
@@ -44,8 +44,8 @@ beforeAll(() => {
         mqttClient = connect(`mqtt://localhost:${MQTT_PORT}`, {
           keepalive: 60,
           reschedulePings: true,
-          // protocolId: 'MQTT',
-          // protocolVersion: 4,
+          protocolId: 'MQTT',
+          protocolVersion: 4,
           reconnectPeriod: 2000,
           connectTimeout: 5 * 1000,
           clean: true

packages/openapi-to-graphql/src/resolver_builder.ts

@@ -25,8 +25,8 @@ openAPIToGraphQL
     const client = connect(`mqtt://localhost:1885`, {
       keepalive: 60,
       reschedulePings: true,
-      // protocolId: 'MQTT',
-      // protocolVersion: 4,
+      protocolId: 'MQTT',
+      protocolVersion: 4,
       reconnectPeriod: 2000,
       connectTimeout: 5 * 1000,
       clean: true