Skip to content

Logos with internationalized text #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azaroth42 opened this issue Dec 7, 2018 · 7 comments · Fixed by #1788
Closed

Logos with internationalized text #1760

azaroth42 opened this issue Dec 7, 2018 · 7 comments · Fixed by #1788
Labels

Comments

@azaroth42
Copy link
Member

Related to #1759, if an organization has multiple logos with text in different languages, then the current restriction of one logo per Agent does not allow the set of logos to be included.

No one has actually asked for this, but to go from single external resource to an array would be a breaking change if it is asked for.

And even still, perhaps it's Anglo-centricity, but I don't think this is important to make without at least canvassing the community to see if anyone would use it.

@eroux
Copy link

eroux commented Dec 17, 2018

We would definitely use that. An idea that just popped up is that our logo is black so ideally there would be a different logo if the background of the viewer is dark (like in UV or Mirador) vs. when it's light (like in Diva).

@azaroth42
Copy link
Member Author

We (Getty) also have dark and light logos, but how the manifest would declare which one to use seems difficult (and beyond the scope of the current issue). However if we allow multiple logos, then there would be the scope to add it in a future release without (hopefully) a backwards incompatible change.

@azaroth42
Copy link
Member Author

azaroth42 commented Jan 9, 2019

Eds (non quorate discussion) - allowing multiple would enable extensions to clarify light/dark or other situations beyond language. Without multiple, then this would be invalid. Could also be big and small logos, with dimensions.

@tomcrane
Copy link
Contributor

tomcrane commented Jan 9, 2019

👍 No objection to multiple logos.

@mikeapp
Copy link
Member

mikeapp commented Jan 9, 2019

👍

2 similar comments
@zimeon
Copy link
Member

zimeon commented Jan 9, 2019

👍

@jpstroop
Copy link
Member

jpstroop commented Jan 9, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants