Skip to content

[ENHANCEMENT] Turn functions isstored, eachstoredindex, etc. into @interface functions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtfishman opened this issue Dec 14, 2024 · 0 comments · Fixed by #52
Closed

[ENHANCEMENT] Turn functions isstored, eachstoredindex, etc. into @interface functions #6

mtfishman opened this issue Dec 14, 2024 · 0 comments · Fixed by #52
Labels
enhancement New feature or request

Comments

@mtfishman
Copy link
Member

The SparseArraysBase minimal interface functions:

  • eachstoredindex
  • getstoredindex
  • getunstoredindex
  • isstored
  • setstoredindex!
  • setunstoredindex!
  • storedlength
  • storedpairs
  • storedvalues
  • ArrayLayouts.zero!

should get turned into @interface functions so they can be customized based on interfaces. There will be different implementations for different types of arrays, such as dense, element-wise sparse, block sparse, etc.
@mtfishman mtfishman added the enhancement New feature or request label Dec 14, 2024
@lkdvos lkdvos linked a pull request Apr 9, 2025 that will close this issue
Rigorous index handling: boundschecks and indexstyle #52
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rigorous index handling: boundschecks and indexstyle ITensor/SparseArraysBase.jl
1 participant
@mtfishman