Skip to content

Commit 1dd217b

Browse files
committed
Have delete borrow its element
As discussed here exercism#114 (diff)
1 parent 72a6fd3 commit 1dd217b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

exercises/custom-set/example.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ impl<T: Ord + Clone> CustomSet<T> {
2525
}
2626
}
2727

28-
pub fn delete(&mut self, element: T) {
29-
self.collection.retain(|x| x != &element)
28+
pub fn delete(&mut self, element: &T) {
29+
self.collection.retain(|x| x != element)
3030
}
3131

3232
pub fn contains(&self, other: &T) -> bool {

exercises/custom-set/tests/custom-set.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,14 @@ fn add_existing_element() {
8282
#[test]
8383
fn delete_an_existing_element() {
8484
let mut set = CustomSet::new(vec![3, 2, 1]);
85-
set.delete(2);
85+
set.delete(&2);
8686
assert_eq!(set, CustomSet::new(vec![1, 3]));
8787
}
8888

8989
#[test]
9090
fn delete_an_nonexistent_element() {
9191
let mut set = CustomSet::new(vec![3, 2, 1]);
92-
set.delete(4);
92+
set.delete(&4);
9393
assert_eq!(set, CustomSet::new(vec![1, 2, 3]));
9494
}
9595

0 commit comments

Comments
 (0)