Refactor create_authn_request message

Signed-off-by: Ivan Kanakarakis <[email protected]>

Author: c00kiemon5ter

src/saml2/client_base.py

@@ -438,17 +438,39 @@ def create_authn_request(self, destination, vorg="", scoping=None,
                 self.sec.cert_handler.update_cert(True, client_crt)
                 if client_crt is not None:
                     sign_prepare = True
-                return self._message(AuthnRequest, destination, message_id,
-                                     consent, extensions, sign, sign_prepare,
-                                     protocol_binding=binding,
-                                     scoping=scoping, nsprefix=nsprefix,
-                                     sign_alg=sign_alg, digest_alg=digest_alg,
-                                     **args)
-        return self._message(AuthnRequest, destination, message_id, consent,
-                             extensions, sign, sign_prepare,
-                             protocol_binding=binding,
-                             scoping=scoping, nsprefix=nsprefix,
-                             sign_alg=sign_alg, digest_alg=digest_alg, **args)
+                msg = self._message(
+                    AuthnRequest,
+                    destination,
+                    message_id,
+                    consent,
+                    extensions,
+                    sign,
+                    sign_prepare,
+                    protocol_binding=binding,
+                    scoping=scoping,
+                    nsprefix=nsprefix,
+                    sign_alg=sign_alg,
+                    digest_alg=digest_alg,
+                    **args,
+                )
+        else:
+            msg = self._message(
+                AuthnRequest,
+                destination,
+                message_id,
+                consent,
+                extensions,
+                sign,
+                sign_prepare,
+                protocol_binding=binding,
+                scoping=scoping,
+                nsprefix=nsprefix,
+                sign_alg=sign_alg,
+                digest_alg=digest_alg,
+                **args,
+            )
+
+        return msg
 
     def create_attribute_query(self, destination, name_id=None,
             attribute=None, message_id=0, consent=None,