Skip to content

Temporary files not removed #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tpazderka opened this issue Aug 8, 2019 · 2 comments · Fixed by #634
Closed

Temporary files not removed #629

tpazderka opened this issue Aug 8, 2019 · 2 comments · Fixed by #634

Comments

@tpazderka
Copy link
Contributor

tpazderka commented Aug 8, 2019

Code Version

4.7.0

Expected Behavior

Clean up the no longer necessary files.

Current Behavior

Calling entitites_descriptor leaves files on disc (2 per call).

Possible Solution

make_temp function creates the temporary files marked as for deletion and passes file descriptor to the caller. It should be possible to just close the file when no longer needed.

Steps to Reproduce

  1. Call entities_descriptor to create a valid XML
  2. Inspect temporary file storage
@peppelinux
Copy link
Member

peppelinux commented Aug 17, 2019

Pysaml2 uses xmlsec1 as system call and It needs a xml file. As other issues related to xmlsec1 already exposed, we're facing the Need to implement a xmlsec wrapper in pure python. This Will let us to decide if use systemcall or xmlsec lib/api for xml validation.

In pysaml2 v4.6.0 and v4.8.0 this problem ALSO exists.

@peppelinux
Copy link
Member

peppelinux commented Aug 17, 2019

Fixed in this PR
#634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants