Skip to content

Commit a1570eb

Browse files
fix: network log unit test
1 parent 55fba6d commit a1570eb

File tree

1 file changed

+11
-31
lines changed

1 file changed

+11
-31
lines changed

android/src/test/java/com/instabug/flutter/ApmApiTest.java

Lines changed: 11 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
package com.instabug.flutter;
22

3+
import static com.instabug.apm.networking.ApmNetworkLoggerHelper.log;
4+
import static com.instabug.flutter.util.GlobalMocks.log;
35
import static com.instabug.flutter.util.GlobalMocks.reflected;
46
import static com.instabug.flutter.util.MockResult.makeResult;
57
import static org.junit.Assert.assertEquals;
68
import static org.mockito.ArgumentMatchers.any;
79
import static org.mockito.ArgumentMatchers.anyInt;
8-
import static org.mockito.ArgumentMatchers.anyString;
910
import static org.mockito.ArgumentMatchers.eq;
1011
import static org.mockito.Mockito.mock;
1112
import static org.mockito.Mockito.mockConstruction;
@@ -18,7 +19,8 @@
1819
import com.instabug.apm.configuration.cp.APMFeature;
1920
import com.instabug.apm.configuration.cp.FeatureAvailabilityCallback;
2021
import com.instabug.apm.model.ExecutionTrace;
21-
import com.instabug.apm.networking.APMNetworkLogger;
22+
import com.instabug.apm.networking.ApmNetworkLoggerHelper;
23+
import com.instabug.apm.networking.mapping.NetworkRequestAttributes;
2224
import com.instabug.flutter.generated.ApmPigeon;
2325
import com.instabug.flutter.modules.ApmApi;
2426
import com.instabug.flutter.util.GlobalMocks;
@@ -37,10 +39,6 @@
3739
import java.util.HashMap;
3840
import java.util.Map;
3941

40-
import static com.instabug.flutter.util.GlobalMocks.reflected;
41-
import static com.instabug.flutter.util.MockResult.makeResult;
42-
import static org.junit.Assert.assertEquals;
43-
import static org.mockito.ArgumentMatchers.*;
4442
import static org.mockito.Mockito.*;
4543

4644

@@ -221,6 +219,8 @@ public void testEndAppLaunch() {
221219

222220
@Test
223221
public void testNetworkLogAndroid() {
222+
final MockedStatic<ApmNetworkLoggerHelper> mApmNetworkLoggerHelper = mockStatic((ApmNetworkLoggerHelper.class));
223+
224224
Map<String, Object> data = new HashMap<>();
225225
String requestUrl = "https://example.com";
226226
String requestBody = "hi";
@@ -237,6 +237,7 @@ public void testNetworkLogAndroid() {
237237
HashMap<String, String> responseHeaders = new HashMap<>();
238238
String errorDomain = "ERROR_DOMAIN";
239239
String serverErrorMessage = "SERVER_ERROR_MESSAGE";
240+
String gqlQueryName = "GQL_QUERY_NAME";
240241
data.put("url", requestUrl);
241242
data.put("requestBody", requestBody);
242243
data.put("responseBody", responseBody);
@@ -254,33 +255,12 @@ public void testNetworkLogAndroid() {
254255
data.put("duration", requestDuration);
255256
data.put("serverErrorMessage", serverErrorMessage);
256257

257-
MockedConstruction<APMNetworkLogger> mAPMNetworkLogger = mockConstruction(APMNetworkLogger.class);
258-
MockedConstruction<JSONObject> mJSONObject = mockConstruction(JSONObject.class, (mock, context) -> when(mock.toString(anyInt())).thenReturn("{}"));
259-
260258
api.networkLogAndroid(data);
261259

262-
reflected.verify(() -> MockReflected.apmNetworkLog(
263-
requestStartTime * 1000,
264-
requestDuration / 1000,
265-
"{}",
266-
requestBody,
267-
requestBodySize,
268-
requestMethod,
269-
requestUrl,
270-
requestContentType,
271-
"{}",
272-
responseBody,
273-
responseBodySize,
274-
responseCode,
275-
responseContentType,
276-
errorDomain,
277-
null,
278-
serverErrorMessage,
279-
null
280-
));
281-
282-
mAPMNetworkLogger.close();
283-
mJSONObject.close();
260+
mApmNetworkLoggerHelper.verify(() -> log(data));
261+
262+
mApmNetworkLoggerHelper.close();
263+
284264
}
285265

286266
@Test

0 commit comments

Comments
 (0)