Merge pull request #1305 from Instabug/chore/validate-release-post-check-job

ci: validate release post check job

Author: AyaMahmoud148

.circleci/config.yml

@@ -154,6 +154,22 @@ commands:
       - run:
           name: Post comment on GitHub
           command: ./scripts/notify-github.sh "<< parameters.data >>"
+  build_and_pack_sdk:
+    parameters:
+      working_directory:
+        type: string
+        default: ~/project
+    steps:
+      - install_node_modules
+      - run:
+          command: yarn build
+          working_directory: ~/project
+      - run:
+          command: yarn pack --filename InstabugSDK.tgz
+          working_directory: ~/project
+      - run:
+          command: yarn add file:../../InstabugSDK.tgz
+          working_directory: <<parameters.working_directory>>
 
 jobs:
   danger:
@@ -295,7 +311,7 @@ jobs:
                 -scheme InstabugExample \
                 -resultBundlePath coverage/result.xcresult \
                 -sdk iphonesimulator \
-                -destination 'platform=iOS Simulator,name=iPhone 13 Pro Max,OS=15.5' \
+                -destination "platform=iOS Simulator,OS=15.5,name=iPhone 11 Pro Max" \
                 test | xcpretty
       - when:
           condition: << parameters.collect_coverage >>
@@ -487,6 +503,50 @@ jobs:
           replace: $SNAPSHOT_VERSION
       - notify_github:
           data: "$(jq -Rcs '{ body: . }' scripts/snapshot-comment.md)"
+  build_check_android:
+    parameters:
+      working_directory:
+        type: string
+    executor:
+      name: android/android-machine
+      tag: '2024.01.1'
+    steps:
+      - advanced-checkout/shallow-checkout
+      - build_and_pack_sdk:
+          working_directory: << parameters.working_directory >>
+      - run:
+          name: Build Android
+          working_directory: <<parameters.working_directory>>/android
+          command: ./gradlew assembleRelease
+
+  build_check_ios:
+    parameters:
+      working_directory:
+        type: string
+      scheme:
+        type: string
+      workspace_path:
+        type: string
+    macos:
+      xcode: 13.4.1
+    resource_class: macos.m1.medium.gen1
+    steps:
+      - advanced-checkout/shallow-checkout
+      - build_and_pack_sdk:
+          working_directory: << parameters.working_directory >>
+      - install_pods:
+          working_directory: <<parameters.working_directory>>/ios
+      - run:
+          name: Build iOS
+          working_directory: <<parameters.working_directory>>/ios
+          command: |
+            yarn react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios/main.jsbundle --assets-dest ios
+            rm -rf ~/Library/Developer/Xcode/DerivedData/*
+            xcodebuild -workspace <<parameters.workspace_path>>.xcworkspace \
+            -scheme <<parameters.scheme>> \
+            -configuration Release \
+            -sdk iphonesimulator \
+            -destination "platform=iOS Simulator,OS=15.5,name=iPhone 11 Pro Max"
 
 workflows:
   publish:
@@ -607,9 +667,37 @@ workflows:
           filters:
             branches:
               only: dream11
+      - hold_build_check:
+          type: approval
+      - build_check_android:
+          name: build_check_android_default
+          working_directory: ~/project/examples/default
+          requires:
+            - hold_build_check
+      - build_check_ios:
+          name: build_check_ios_default
+          working_directory: ~/project/examples/default
+          scheme: InstabugExample
+          workspace_path: InstabugExample
+          requires:
+            - hold_build_check
+      - build_check_android:
+          name: build_check_android_hybrid
+          working_directory: ~/project/examples/hybrid
+          requires:
+            - hold_build_check
+      - build_check_ios:
+          name: build_check_ios_hybrid
+          working_directory: ~/project/examples/hybrid
+          scheme: HybridSampleApp
+          workspace_path: HybridSampleApp
+          requires:
+            - hold_build_check
       - release_custom_package:
           name: release_dream11
           requires:
+            - build_check_android_hybrid
+            - build_check_ios_hybrid
             - hold_release_dream11
           filters:
             branches:

examples/hybrid/ios/HybridSampleApp.xcodeproj/project.pbxproj

@@ -55,7 +55,7 @@
       </Testables>
    </TestAction>
    <LaunchAction
-      buildConfiguration = "Debug"
+      buildConfiguration = "Release"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       launchStyle = "0"

examples/hybrid/ios/HybridSampleApp.xcodeproj/xcshareddata/xcschemes/HybridSampleApp.xcscheme

@@ -1,5 +1,5 @@
 #import <UIKit/UIKit.h>
 
 @interface AppDelegate : UIResponder <UIApplicationDelegate>
-
+@property (nonatomic, strong) UIWindow *window;  // Add this property
 @end

examples/hybrid/ios/HybridSampleApp/AppDelegate.h

@@ -2,29 +2,39 @@
 #import <React/RCTRootView.h>
 #import <Instabug/Instabug.h>
 #import <Instabug/IBGCrashReporting.h>
-@interface MainViewController ()
-
+#import <React/RCTBundleURLProvider.h>
+#import <React/RCTBridge.h>
+@interface MainViewController () <RCTBridgeDelegate>
+@property (nonatomic, strong) RCTBridge *bridge;
 @end
 
 @implementation MainViewController
 
 - (void)viewDidLoad {
     [super viewDidLoad];
-    // Do any additional setup after loading the view.
+    self.bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:nil];
 }
-- (IBAction)startReactNative:(UIButton *)sender {
-    NSURL *jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/index.bundle?platform=ios"];
 
-    RCTRootView *rootView =
-          [[RCTRootView alloc] initWithBundleURL: jsCodeLocation
-                                      moduleName: @"HybridSampleApp"
-                               initialProperties:nil
-launchOptions: nil];
-        UIViewController *vc = [[UIViewController alloc] init];
-        vc.view = rootView;
-        [self presentViewController:vc animated:YES completion:nil];
+- (IBAction)startReactNative:(UIButton *)sender {
+    RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:self.bridge
+                                                    moduleName:@"HybridSampleApp"
+                                             initialProperties:nil];
+    
+    UIViewController *vc = [[UIViewController alloc] init];
+    vc.view = rootView;
+    [self presentViewController:vc animated:YES completion:nil];
 }
 
+// This will now be called by the bridge
+- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
+{
+    NSLog(@"sourceURLForBridge called!"); // This will now print
+#if DEBUG
+    return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
+#else
+    return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
+#endif
+}
 - (IBAction)throwHandled:(UIButton *)sender {
     NSException *exception = [NSException exceptionWithName:@"Objective-C Handled Exception"
                                                      reason:@"no reason"

examples/hybrid/ios/HybridSampleApp/MainViewController.m

@@ -5,20 +5,27 @@ require_relative '../node_modules/@react-native-community/cli-platform-ios/nativ
 platform :ios, '13.4'
 prepare_react_native_project!
 
+linkage = ENV['USE_FRAMEWORKS']
+if linkage != nil
+  Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
+  use_frameworks! :linkage => linkage.to_sym
+end
 
 target 'HybridSampleApp' do
   config = use_native_modules!
+  # Flags change depending on the env values.
+  flags = get_default_flags()
 
   use_react_native!(
     :path => config[:reactNativePath],
-    :hermes_enabled => false,
     # Hermes is now enabled by default. Disable by setting this flag to false.
     # Upcoming versions of React Native may rely on get_default_flags(), but
     # we make it explicit here to aid in the React Native upgrade process.
+    :hermes_enabled => flags[:hermes_enabled],
+    :fabric_enabled => flags[:fabric_enabled],
     # An absolute path to your application root.
     :app_path => "#{Pod::Config.instance.installation_root}/.."
   )
-  pod 'Instabug', '~> 13.4.2'
 
   post_install do |installer|
     react_native_post_install(