-
Notifications
You must be signed in to change notification settings - Fork 9
MOB 8472 #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
MOB 8472 #390
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9ba876a
pushed changes
hardikmashru a5e0831
Merge branch 'embedded-ga' into embedded-test-working
hardikmashru 2733e13
Update LoginForm.tsx
hardikmashru 5bb69f3
fix cardView, notificationView, bannerView
hardikmashru af20d01
fix aspect-ratio, padding
hardikmashru 860baf4
fix margin-top for banner image
hardikmashru cccda09
revert LoginForm changes
hardikmashru c4c6f98
final fix card, banner, notification view
hardikmashru 5e583fd
Merge branch 'embedded-ga' into MOB-8472
harrymash2006 836ca01
UI fixes, responsive fixes and impression tracker screen fixes
hardikmashru 8c2737d
put back env.example
hardikmashru 73ab5a1
rename env.example
hardikmashru 5fbd360
removed inline style
hardikmashru 4611e4a
rollback for unnecessary PR diff
hardikmashru 12afd24
Update index.tsx
hardikmashru c9a9a5d
update .evn.example
hardikmashru 3f947d9
fix card, banner, notification view
hardikmashru 63a94e2
updates
hardikmashru 6f25f0a
escape htmltext
hardikmashru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,15 @@ | ||
# To make requests from this example app make sure you first create an .env file | ||
# and add the API key and JWT Secret to it like so (and uncomment the keys): | ||
# API_KEY=1234 | ||
# JWT_SECRET=1234 | ||
# Optional environment variables for local development. Start by creating a | ||
# called .env and add these values to it and change them appropriately. | ||
# Remember to uncomment the variables! | ||
|
||
# Only set BASE_URL if developing locally, as it will take precedence over the production api urls. | ||
# BASE_URL="https://api.iterable.com/api" | ||
|
||
# You can set the URL for the JWT generator here if needed | ||
# JWT_GENERATOR=http://localhost:5000/generate | ||
# JWT_GENERATOR=http://localhost:3000/generate | ||
|
||
# Set this to false to prevent messages from being consumed to fetch the same message(s) when testing changes locally. | ||
# ENABLE_INAPP_CONSUME=false | ||
|
||
# Convenience variable to automatically set the login email during testing. | ||
# [email protected] | ||
# Toggle this to true if you would need to hit our EU APIs. | ||
# IS_EU_ITERABLE_SERVICE=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add back the
JWT_GENERATOR
var here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mprew97 sure, will do that and also handle the other issues you reported on the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mprew97 all suggested fixes are done, except the image one as NOT able to reproduce. It will be helpful to reproduce if you can send the link of the image used in the screenshot you sent.