From e2d40bba122e8e3ec96b725bc5ac6ea2b8651754 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 10:24:52 -0400 Subject: [PATCH 01/16] add first playwright test --- react-example/e2e/pages/commercePage.ts | 60 +++++++++++++++++++++++++ react-example/e2e/test/commerce.spec.ts | 43 ++++++++++++++++++ react-example/playwright.config.ts | 5 +-- react-example/src/views/Commerce.tsx | 22 +++++++-- 4 files changed, 123 insertions(+), 7 deletions(-) create mode 100644 react-example/e2e/pages/commercePage.ts create mode 100644 react-example/e2e/test/commerce.spec.ts diff --git a/react-example/e2e/pages/commercePage.ts b/react-example/e2e/pages/commercePage.ts new file mode 100644 index 00000000..2a298dd8 --- /dev/null +++ b/react-example/e2e/pages/commercePage.ts @@ -0,0 +1,60 @@ +import { type Locator, type Page } from '@playwright/test'; + +export class CommercePage { + readonly page: Page; + readonly cartInput: Locator; + readonly purchaseInput: Locator; + readonly cartSubmitButton: Locator; + readonly purchaseSubmitButton: Locator; + readonly cartResponse: Locator; + readonly purchaseResponse: Locator; + + constructor(page: Page) { + this.page = page; + this.cartInput = page.getByTestId('cart-input'); + this.cartSubmitButton = page.getByTestId('cart-submit'); + this.cartResponse = page.getByTestId('cart-response'); + this.purchaseInput = page.getByTestId('purchase-input'); + this.purchaseSubmitButton = page.getByTestId('purchase-submit'); + this.purchaseResponse = page.getByTestId('purchase-response'); + } + + async goto() { + await this.page.goto('/commerce'); + } + + async mock200POSTPurchaseRequest() { + await this.page.route( + 'https://api.iterable.com/api/commerce/trackPurchase', + async (route) => { + const json = { + msg: 'success mocked from playwright', + code: 'Success', + params: { + id: 'mock-playwright-id' + } + }; + await route.fulfill({ json }); + } + ); + } + + async mock400POSTPurchaseRequest() { + await this.page.route( + 'https://api.iterable.com/api/commerce/trackPurchase', + async (route) => { + const json = { + code: 'GenericError', + msg: 'Client-side error mocked from playwright', + clientErrors: [ + { + error: 'items[0].name is a required field', + field: 'items[0].name' + } + ] + }; + await route.fulfill({ json }); + } + ); + } +} diff --git a/react-example/e2e/test/commerce.spec.ts b/react-example/e2e/test/commerce.spec.ts new file mode 100644 index 00000000..424e4360 --- /dev/null +++ b/react-example/e2e/test/commerce.spec.ts @@ -0,0 +1,43 @@ +import { test, expect } from '@playwright/test'; +import { CommercePage } from '../pages/commercePage'; + +test.describe('Commerce tests', () => { + test.beforeEach(async ({ page }) => { + const commercePage = new CommercePage(page); + await commercePage.goto(); + }); + + test('200 POST purchase request', async ({ page }) => { + const commercePage = new CommercePage(page); + await commercePage.mock200POSTPurchaseRequest(); + + await commercePage.purchaseInput.fill('SomeItem'); + await commercePage.purchaseSubmitButton.click(); + await expect(commercePage.purchaseResponse).toContainText( + JSON.stringify({ + msg: 'success mocked from playwright', + code: 'Success', + params: { + id: 'mock-playwright-id' + } + }) + ); + }); + + test('400 POST purchase request', async ({ page }) => { + const commercePage = new CommercePage(page); + await commercePage.mock400POSTPurchaseRequest(); + + await commercePage.purchaseInput.fill('SomeItem'); + await commercePage.purchaseSubmitButton.click(); + await expect(commercePage.purchaseResponse).toContainText( + JSON.stringify({ + code: 'GenericError', + msg: 'Client-side error mocked from playwright', + clientErrors: [ + { error: 'items[0].name is a required field', field: 'items[0].name' } + ] + }) + ); + }); +}); diff --git a/react-example/playwright.config.ts b/react-example/playwright.config.ts index 7e2134fc..dc6827c8 100644 --- a/react-example/playwright.config.ts +++ b/react-example/playwright.config.ts @@ -23,9 +23,8 @@ export default defineConfig({ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ use: { - /* Base URL to use in actions like `await page.goto('/')`. */ - // baseURL: 'http://127.0.0.1:3000', - + baseURL: 'http://127.0.0.1:8080', + testIdAttribute: 'data-test', /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ trace: 'on-first-retry' }, diff --git a/react-example/src/views/Commerce.tsx b/react-example/src/views/Commerce.tsx index ce7a7347..0f4d6f3b 100644 --- a/react-example/src/views/Commerce.tsx +++ b/react-example/src/views/Commerce.tsx @@ -67,34 +67,48 @@ export const Commerce: FC = () => {
setCartItem(e.target.value)} id="item-1" placeholder="e.g. keyboard" data-qa-cart-input /> - - {updateCartResponse} + + {updateCartResponse} + POST /trackPurchase
setPurchaseItem(e.target.value)} id="item-2" placeholder="e.g. keyboard" data-qa-purchase-input /> - - {trackPurchaseResponse} + + {trackPurchaseResponse} +
); From b54c2852df74f3f058f8c37265f44e67134faa8f Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 10:36:00 -0400 Subject: [PATCH 02/16] add github actions for e2e --- .github/workflows/e2e.yml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 .github/workflows/e2e.yml diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml new file mode 100644 index 00000000..78a0a775 --- /dev/null +++ b/.github/workflows/e2e.yml @@ -0,0 +1,26 @@ +# This workflow will do a clean install of node dependencies, cache/restore them, +# build the source code and run tests + +# source: https://github.com/actions/starter-workflows/blob/main/ci/node.js.yml + +name: e2e + +on: + push: + branches: + - main + pull_request: + +jobs: + build: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - name: Use Node.js 16.3.0 + uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 + with: + node-version: '16.3.0' + cache: 'yarn' + - run: yarn install:all && yarn start:all:react + - run: yarn playwright test From 3fa1bdd5433266b48d9770a83cef4c1f0b30afcb Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 10:38:15 -0400 Subject: [PATCH 03/16] fix node version for GA --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 78a0a775..75f077b3 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -20,7 +20,7 @@ jobs: - name: Use Node.js 16.3.0 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: '16.3.0' + node-version: '20.10.0' cache: 'yarn' - run: yarn install:all && yarn start:all:react - run: yarn playwright test From dc45b2e50276c2210019f6bb74a3bb033d925f24 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 14:22:25 -0400 Subject: [PATCH 04/16] add playwright install and webpack update --- .github/workflows/e2e.yml | 22 +++++++++++++++++----- webpack.config.js | 12 +++++++++++- 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 75f077b3..4540c184 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -12,15 +12,27 @@ on: pull_request: jobs: - build: + test: runs-on: ubuntu-latest - + timeout-minutes: 60 steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - - name: Use Node.js 16.3.0 + - name: Use Node.js 20.10.0 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: node-version: '20.10.0' cache: 'yarn' - - run: yarn install:all && yarn start:all:react - - run: yarn playwright test + - name: Install dependencies + run: yarn install --frozen-lockfile + - name: Start React Sample App + run: yarn start:all:react + - name: Install Playwright Browsers + run: yarn playwright install --with-deps + - name: Run Playwright tests + run: yarn playwright test + - uses: actions/upload-artifact@v4 + if: ${{ !cancelled() }} + with: + name: playwright-report + path: playwright-report/ + retention-days: 30 diff --git a/webpack.config.js b/webpack.config.js index 81c17808..1ab30601 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -33,7 +33,17 @@ module.exports = { }), new MiniCssExtractPlugin({ filename: 'dist/components/style.css' // Output CSS filename - }) + }), + { + apply: (compiler) => { + compiler.hooks.done.tap('DonePlugin', (stats) => { + console.log('Compile is done !'); + setTimeout(() => { + process.exit(0); + }); + }); + } + } ], module: { rules: [ From f7df298783435748823d613cbbdcb479fab967f3 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 14:31:48 -0400 Subject: [PATCH 05/16] fix typo --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 4540c184..75bbdec6 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -12,7 +12,7 @@ on: pull_request: jobs: - test: + build: runs-on: ubuntu-latest timeout-minutes: 60 steps: From 02446d4b129ee8d239ae8cf99e8b1698b85af5a3 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 14:36:25 -0400 Subject: [PATCH 06/16] fix github actions --- .github/workflows/e2e.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 75bbdec6..ad909db6 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -1,8 +1,3 @@ -# This workflow will do a clean install of node dependencies, cache/restore them, -# build the source code and run tests - -# source: https://github.com/actions/starter-workflows/blob/main/ci/node.js.yml - name: e2e on: @@ -10,11 +5,14 @@ on: branches: - main pull_request: + branches: + - main jobs: build: runs-on: ubuntu-latest timeout-minutes: 60 + steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - name: Use Node.js 20.10.0 From d9b5b3f6dc858d285785ec2506ad9ff510d52279 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 16:11:51 -0400 Subject: [PATCH 07/16] Trigger Build From c0e7d399c3c5fc85a50f29a3bf965ebf2f615e39 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 16:23:00 -0400 Subject: [PATCH 08/16] github actions try again --- .github/workflows/e2e.yml | 2 +- react-example/webpack.config.js | 13 ++++++++++++- webpack.config.js | 12 +----------- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index ad909db6..d5c5a3fe 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -23,7 +23,7 @@ jobs: - name: Install dependencies run: yarn install --frozen-lockfile - name: Start React Sample App - run: yarn start:all:react + run: yarn install:all && yarn start:all:react - name: Install Playwright Browsers run: yarn playwright install --with-deps - name: Run Playwright tests diff --git a/react-example/webpack.config.js b/react-example/webpack.config.js index d4adb6b0..ba00250f 100644 --- a/react-example/webpack.config.js +++ b/react-example/webpack.config.js @@ -58,6 +58,17 @@ module.exports = { }), new MiniCssExtractPlugin({ filename: '[name].css' - }) + }), + // Exit the process when built successfully + { + apply: (compiler) => { + compiler.hooks.done.tap('DonePlugin', (stats) => { + console.log('Compile is done !'); + setTimeout(() => { + process.exit(0); + }); + }); + } + } ] }; diff --git a/webpack.config.js b/webpack.config.js index 1ab30601..81c17808 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -33,17 +33,7 @@ module.exports = { }), new MiniCssExtractPlugin({ filename: 'dist/components/style.css' // Output CSS filename - }), - { - apply: (compiler) => { - compiler.hooks.done.tap('DonePlugin', (stats) => { - console.log('Compile is done !'); - setTimeout(() => { - process.exit(0); - }); - }); - } - } + }) ], module: { rules: [ From 16452686e96555849cf490e650ae951cdefce473 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 16:59:26 -0400 Subject: [PATCH 09/16] modify github actions steps --- .github/workflows/e2e.yml | 8 +++++--- react-example/webpack.config.js | 13 +------------ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index d5c5a3fe..d7608586 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -21,11 +21,13 @@ jobs: node-version: '20.10.0' cache: 'yarn' - name: Install dependencies - run: yarn install --frozen-lockfile - - name: Start React Sample App - run: yarn install:all && yarn start:all:react + run: | + rm -rf node_modules && rm -rf ./react-example/node_modules + yarn install:all --frozen-lockfile - name: Install Playwright Browsers run: yarn playwright install --with-deps + - name: Start React Sample App + run: yarn start:all:react - name: Run Playwright tests run: yarn playwright test - uses: actions/upload-artifact@v4 diff --git a/react-example/webpack.config.js b/react-example/webpack.config.js index ba00250f..d4adb6b0 100644 --- a/react-example/webpack.config.js +++ b/react-example/webpack.config.js @@ -58,17 +58,6 @@ module.exports = { }), new MiniCssExtractPlugin({ filename: '[name].css' - }), - // Exit the process when built successfully - { - apply: (compiler) => { - compiler.hooks.done.tap('DonePlugin', (stats) => { - console.log('Compile is done !'); - setTimeout(() => { - process.exit(0); - }); - }); - } - } + }) ] }; From 872dbc94a9e62d4e7eda155cad007bb9cd8f5510 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 17:08:25 -0400 Subject: [PATCH 10/16] try again --- .github/workflows/e2e.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index d7608586..fcea0d16 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -9,8 +9,10 @@ on: - main jobs: - build: + playwright: runs-on: ubuntu-latest + container: + image: mcr.microsoft.com/playwright:v1.45.0-jammy timeout-minutes: 60 steps: @@ -23,7 +25,7 @@ jobs: - name: Install dependencies run: | rm -rf node_modules && rm -rf ./react-example/node_modules - yarn install:all --frozen-lockfile + yarn install --frozen-lockfile && yarn --cwd ./react-example install --frozen-lockfile - name: Install Playwright Browsers run: yarn playwright install --with-deps - name: Start React Sample App From 3ce4000739f43cb44435c90a843bea5555e87e32 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 28 Jun 2024 17:11:31 -0400 Subject: [PATCH 11/16] remove install playwright, use image --- .github/workflows/e2e.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index fcea0d16..37641383 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -26,8 +26,6 @@ jobs: run: | rm -rf node_modules && rm -rf ./react-example/node_modules yarn install --frozen-lockfile && yarn --cwd ./react-example install --frozen-lockfile - - name: Install Playwright Browsers - run: yarn playwright install --with-deps - name: Start React Sample App run: yarn start:all:react - name: Run Playwright tests From 70dc31cbdc252dd6b0223bd0763e8e7d596580d8 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Wed, 10 Jul 2024 13:51:23 -0400 Subject: [PATCH 12/16] change watch config --- react-example/package.json | 2 +- react-example/webpack.config.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/react-example/package.json b/react-example/package.json index e9c18611..171ca206 100644 --- a/react-example/package.json +++ b/react-example/package.json @@ -20,7 +20,7 @@ ], "scripts": { "build": "tsc && webpack", - "start": "concurrently \"tsc -w --pretty\" \"webpack-dev-server\" -n 'tsc,webpack' -k", + "start": "concurrently \"tsc -w --pretty\" \"webpack-dev-server\" -n 'tsc,webpack' -k --watch", "test": "jest --config jest.config.js", "format": "prettier --write \"src/**/*.{ts,tsx}\" \"src/**/*.js\"", "typecheck": "tsc --noEmit true --emitDeclarationOnly false", diff --git a/react-example/webpack.config.js b/react-example/webpack.config.js index d4adb6b0..71f41019 100644 --- a/react-example/webpack.config.js +++ b/react-example/webpack.config.js @@ -12,6 +12,7 @@ module.exports = { filename: 'index.js', path: path.resolve(__dirname, 'dist') }, + watch: process.argv.indexOf('--watch') > -1, module: { rules: [ { From 17b35036d62075f9dddb2c7c68cd6b4b01664068 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Wed, 10 Jul 2024 14:37:02 -0400 Subject: [PATCH 13/16] start-without-watch --- .github/workflows/e2e.yml | 2 +- package.json | 3 ++- react-example/package.json | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 37641383..6ed464f1 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -27,7 +27,7 @@ jobs: rm -rf node_modules && rm -rf ./react-example/node_modules yarn install --frozen-lockfile && yarn --cwd ./react-example install --frozen-lockfile - name: Start React Sample App - run: yarn start:all:react + run: yarn start:all:react-without-watch - name: Run Playwright tests run: yarn playwright test - uses: actions/upload-artifact@v4 diff --git a/package.json b/package.json index e93efb54..39400da7 100644 --- a/package.json +++ b/package.json @@ -46,6 +46,7 @@ "install:all": "yarn && cd example && yarn && cd ../react-example && yarn", "start:all": "concurrently \"yarn start\" \"cd example && yarn start\" -n 'module,website' -k", "start:all:react": "concurrently \"yarn start\" \"cd react-example && yarn start\" -n 'module,website' -k", + "start:all:react-start-without-watch": "concurrently \"yarn start\" \"cd react-example && yarn start-without-watch\" -n 'module,website' -k", "build": "ttsc && babel src --out-dir ./dist --extensions '.ts,.tsx' && webpack", "build:node": "yarn build --config webpack.node.config.js", "test": "jest --config jest.config.js --collectCoverage", @@ -113,4 +114,4 @@ "eslint" ] } -} \ No newline at end of file +} diff --git a/react-example/package.json b/react-example/package.json index 171ca206..fdf2184d 100644 --- a/react-example/package.json +++ b/react-example/package.json @@ -21,11 +21,11 @@ "scripts": { "build": "tsc && webpack", "start": "concurrently \"tsc -w --pretty\" \"webpack-dev-server\" -n 'tsc,webpack' -k --watch", + "start-without-watch": "concurrently \"tsc -w --pretty\" \"webpack-dev-server\" -n 'tsc,webpack' -k", "test": "jest --config jest.config.js", "format": "prettier --write \"src/**/*.{ts,tsx}\" \"src/**/*.js\"", "typecheck": "tsc --noEmit true --emitDeclarationOnly false", - "lint": "eslint . --ext '.ts,.tsx'", - "cypress": "cypress open" + "lint": "eslint . --ext '.ts,.tsx'" }, "devDependencies": { "@babel/core": "^7.5.0", From 41c7c2672aba30d8e20f2beea4720fa89858993c Mon Sep 17 00:00:00 2001 From: jyu115 Date: Wed, 10 Jul 2024 14:46:38 -0400 Subject: [PATCH 14/16] fix command typo --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 6ed464f1..ea82555b 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -27,7 +27,7 @@ jobs: rm -rf node_modules && rm -rf ./react-example/node_modules yarn install --frozen-lockfile && yarn --cwd ./react-example install --frozen-lockfile - name: Start React Sample App - run: yarn start:all:react-without-watch + run: yarn start:all:react-start-without-watch - name: Run Playwright tests run: yarn playwright test - uses: actions/upload-artifact@v4 From 3345a08dc5020bea9f441e9a44a8c9ddb3fe632b Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 12 Jul 2024 11:24:51 -0400 Subject: [PATCH 15/16] babel no watch --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 39400da7..1174f342 100644 --- a/package.json +++ b/package.json @@ -43,10 +43,11 @@ }, "scripts": { "start": "concurrently \"ttsc -w\" \"babel src --watch --out-dir ./dist --extensions '.ts,.tsx'\" \"webpack-dev-server --config webpack.dev.config.js\" -n 'tsc,babel,webpack' -k", + "start-without-watch": "concurrently \"webpack-dev-server --config webpack.dev.config.js\" -n 'tsc,webpack' -k", "install:all": "yarn && cd example && yarn && cd ../react-example && yarn", "start:all": "concurrently \"yarn start\" \"cd example && yarn start\" -n 'module,website' -k", "start:all:react": "concurrently \"yarn start\" \"cd react-example && yarn start\" -n 'module,website' -k", - "start:all:react-start-without-watch": "concurrently \"yarn start\" \"cd react-example && yarn start-without-watch\" -n 'module,website' -k", + "start-without-watch:all:react": "concurrently \"yarn start-without-watch\" \"cd react-example && yarn start-without-watch\" -n 'module,website' -k", "build": "ttsc && babel src --out-dir ./dist --extensions '.ts,.tsx' && webpack", "build:node": "yarn build --config webpack.node.config.js", "test": "jest --config jest.config.js --collectCoverage", From 7325227ddb116b335777ffaf60d57b987aec1045 Mon Sep 17 00:00:00 2001 From: jyu115 Date: Fri, 12 Jul 2024 11:28:00 -0400 Subject: [PATCH 16/16] rename command --- .github/workflows/e2e.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index ea82555b..33b52c92 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -27,7 +27,7 @@ jobs: rm -rf node_modules && rm -rf ./react-example/node_modules yarn install --frozen-lockfile && yarn --cwd ./react-example install --frozen-lockfile - name: Start React Sample App - run: yarn start:all:react-start-without-watch + run: yarn start-without-watch:all:react - name: Run Playwright tests run: yarn playwright test - uses: actions/upload-artifact@v4