Official stance on c++17 support?

[kalmard0]

After recent changes, inkcpp doesn't compile with the c++17 standard. For me personally this is an issue, as I'm working with development targets whose official compiler support is stuck on c++17.

If inkcpp is supposed to officially continue to support c++17, I can try to send some PRs to enforce that (e.g. in automated tests) and clear up the small changes. If not, I will work around the issue in other ways.

[kalmard0]

To be more precise, the specific issue:

src/third_party/inkcpp/inkcpp-master/inkcpp_compiler/json_compiler.cpp:141:56: error: no member named 'starts_with' in
'std::basic_string<char>'; did you mean '_Starts_with'?
  141 |                 if (name_override.starts_with("c-") || name_override.starts_with("g-")) {
      |                                                                      ^~~~~~~~~~~
      |                                                                      _Starts_with

This makes sense as starts_with (https://en.cppreference.com/w/cpp/string/basic_string/starts_with) is a c++20 feature.

However now I see in cmake files that compilation is supposed to be forced to c++17 already, which makes me wonder how this change got past the tests.

[kalmard0]

I just found two opposing pieces of cmake configuration for setting language rules:
SET(CMAKE_CXX_STANDARD 20) and target_compile_features(inkcpp_compiler PUBLIC cxx_std_17). I suspect the former overrides the latter.

[kalmard0]

Another issue I found: some features that are heavily used in inkcpp are C++20-only on MSVC but pass on other compilers. For example:

D:\a\inkcpp\inkcpp\inkcpp_c\inkcpp.cpp(38,8): error C7555: use of designated initializers requires at least '/std:c++20' [D:\a\inkcpp\inkcpp\build\inkcpp_c\inkcpp_c.vcxproj]

[JBenda]

We started the development with C++20 and at some point we noticed/thought that we do not use enough features to justify it. So we were convinced that we were compiling with C++17

Thank you for spotting the Cmake "conflict".
I will see what to do about the designated initializer error and check your others PRs

Thank you a lot for pointing out the problem and for providing partial solutions.

[JBenda]

see #110

[JBenda]

#110