Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

Evaluate ecmaFeatures option #21

Closed
kaicataldo opened this issue Oct 27, 2018 · 1 comment
Closed

Evaluate ecmaFeatures option #21

kaicataldo opened this issue Oct 27, 2018 · 1 comment

Comments

@kaicataldo
Copy link
Collaborator

kaicataldo commented Oct 27, 2018

What version of TypeScript are you using?
N/A

What version of typescript-estree are you using?
master

What code were you trying to parse?
N/A

What did you expect to happen?
N/A

What actually happened?
N/A

Had a thought while I was looking at eslint/typescript-eslint-parser#530. Now that the ESLint-compatibility layer has been separated out, does it make sense to keep the ecmaFeatures option? It looks as though it's only used to enable JSX.

I'm not entirely sure ecmaFeatures makes sense for this package - perhaps we could just add either a jsx: true or enableJSX: true option?

We could always make this backwards compatible, if that's a worry. I'm more than happy to make a PR!

@JamesHenry
Copy link
Owner

Thanks again for doing this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants