Remove debug bound on pin generics #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robamu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous auto-implementation automatically added
Debugbounds on all pin instances. However, not every HAL might have a debug implementation on the pin structures.I think it would be better for this library if the pins do not have that bound. It makes the library easier to use, because each time those bounds are violated, I have to fork a HAL and add the debug bound manually (which can be non-trivial, e.g. in the case of the Raspberry Pi Pico HAL). I am a big fan of adding the Debug bound on every public structure in my libraries, but I think in this case the advantages of losing a little bit of information (not that much, the user can still see whether it is a 4 or 8 pin bus) and increase the flexibility of the library are worth it.