Skip to content

Commit 24546c2

Browse files
authored
Refactors and fixes cross_validate. See #4.
2 parents b740ab6 + 2dac58b commit 24546c2

File tree

4 files changed

+223
-64
lines changed

4 files changed

+223
-64
lines changed

gumbi/arrays.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ def stack(uarray_list, axis=0) -> UncertainArray:
643643

644644
def nlpd(self, target) -> float:
645645
"""Negative log posterior density"""
646-
return -np.log(self.predictions.dist.pdf(target))
646+
return -np.log(self.dist.pdf(target))
647647

648648
def EI(self, target, best_yet, k=1) -> float:
649649
"""Expected improvement

gumbi/regression/GP_pymc3.py

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,21 @@ def __init__(self, dataset: DataSet, outputs=None, seed=2021):
209209
self.gp_dict = None
210210
self.MAP = None
211211

212+
self.continuous_kernel = 'ExpQuad'
213+
self.heteroskedastic_inputs = False
214+
self.heteroskedastic_outputs = True
215+
self.sparse = False
216+
self.n_u = 100
217+
218+
self.model_specs = {
219+
'seed': self.seed,
220+
'continuous_kernel': self.continuous_kernel,
221+
'heteroskedastic_inputs': self.heteroskedastic_inputs,
222+
'heteroskedastic_outputs': self.heteroskedastic_outputs,
223+
'sparse': self.sparse,
224+
'n_u': self.n_u,
225+
}
226+
212227
################################################################################
213228
# Model building and fitting
214229
################################################################################
@@ -323,6 +338,21 @@ def build_model(self, seed=None, continuous_kernel='ExpQuad', heteroskedastic_in
323338
X, y = self.get_shaped_data('mean')
324339

325340
seed = self.seed if seed is None else seed
341+
self.seed = seed
342+
self.continuous_kernel = continuous_kernel
343+
self.heteroskedastic_inputs = heteroskedastic_inputs
344+
self.heteroskedastic_outputs = heteroskedastic_outputs
345+
self.sparse = sparse
346+
self.n_u = n_u
347+
348+
self.model_specs = {
349+
'seed': seed,
350+
'continuous_kernel': continuous_kernel,
351+
'heteroskedastic_inputs': heteroskedastic_inputs,
352+
'heteroskedastic_outputs': heteroskedastic_outputs,
353+
'sparse': sparse,
354+
'n_u': n_u,
355+
}
326356

327357
n_l = len(self.linear_dims)
328358
n_s = len(self.continuous_dims)

0 commit comments

Comments
 (0)