Update SetupAllEntities.cs #67
Conversation
While debugging my application, I discovered that one of my singleton services were being instantiated twice. I realized that this was due to GenericServicesSimpleSetup building the DI container (SetupAllEntities.cs:20) in order to resolve the DbContext. Since my DbContext depended on a singleton service, it was instantiated twice: once during setup, and again when the application built the root DI container. My question is this: The temporary IServiceProvider that is built in SetupAllEntities doesn't seem to be used anywhere else. Could it be disposed after resolving the DbContext(s)? Currently you dispose the service scope, but this doesn't trigger Dispose on singleton services.
|
Hi @JonathanQuinth, OK, I will look at that but it won't be immediately as I am in the middle of complex library. I could accept your PR but I want to see if I can remove the building of the |
|
Hi @JonathanQuinth, Version 5.2.0-preview001 of the GenericServices to not register the EF Core entities on startup, but when a entity is first used. It passes all the ~300 unit tests but could you try this NuGet in your app any let me know if it works. It definitely doesn't builds a temporary services on registration, but just check it works as normal. Once you confirm it works, then I will release this version as 5.2.1. |
|
Hej @JonPSmith, I can analyze the problem in the context of my app a little more next week if that helps you. Have a good one! |
|
I'm glad sent you a preview, but bad it didn't work! I did manage to get the unit tests to show the problem, but it also showed that it would be take a big change to the setup code, because so many things, like DTO matchings, AutoMapper setup, etc. are done startup. I know that you aren't supposed to build the DI service while all the services haven't be set up but a redesign of the startup code is really difficult, so I have used this PR. I have created a 5.2.1-preview001 for you check. I know you have done this yourself, but I would like you confirm the NuGet works before I release it. |
|
Hi Jon! |
|
I have just released version 5.2.1 with the fix and unlisted the 5.2.1-preview001 version. Please swap over to version 5.2.1 when you can. |
ghost
deleted the
|
Thank you! |
While debugging my application, I discovered that one of my singleton services were being instantiated twice. I realized that this was due to GenericServicesSimpleSetup building the DI container (SetupAllEntities.cs:20) in order to resolve the DbContext. Since my DbContext depended on a singleton service, it was instantiated twice: once during setup, and again when the application built the root DI container.
My question is this: The temporary IServiceProvider that is built in SetupAllEntities doesn't seem to be used anywhere else. Could it be disposed after resolving the DbContext(s)? Currently you dispose the service scope, but this doesn't trigger Dispose on singleton services.