Skip to content

Commit 4fbfefe

Browse files
authored
Merge pull request #35 from JuliaComputing/sp/no-wait-for-open_browser-cmds
fix: stop waiting for browsers
2 parents 737309d + e1283ed commit 4fbfefe

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/CI.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ jobs:
2727
- '1.4'
2828
- '1.5'
2929
- '1.6'
30-
# - '1.7' # TODO: uncomment this line once Julia 1.8 is released
31-
- '~1.8.0-rc1' # TODO: delete this line once Julia 1.8 is released
30+
- '1.7'
31+
- '1.8'
32+
- '1.9'
3233
- '1' # automatically expands to the latest stable 1.x release
3334
- 'nightly'
3435
os:

src/PkgAuthentication.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -521,11 +521,11 @@ function open_browser(url::AbstractString)
521521
return false
522522
end
523523
elseif Sys.iswindows()
524-
run(`cmd /c "start $url"`)
524+
run(`cmd /c "start $url"`; wait=false)
525525
elseif Sys.isapple()
526-
run(`open $url`)
526+
run(`open $url`; wait=false)
527527
elseif Sys.islinux() || Sys.isbsd()
528-
run(`xdg-open $url`)
528+
run(`xdg-open $url`; wait=false)
529529
end
530530
catch err
531531
@warn "There was a problem opening the authentication URL in a browser, please try opening this URL manually to authenticate." url, error = err

0 commit comments

Comments
 (0)