Skip to content

llvmcall opaque pointers#68

Open
svchb wants to merge 4 commits intoJuliaConcurrent:mainfrom
svchb:issue_65
Open

llvmcall opaque pointers#68
svchb wants to merge 4 commits intoJuliaConcurrent:mainfrom
svchb:issue_65

Conversation

@svchb
Copy link

@svchb svchb commented Feb 4, 2026

Fix issue #65

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.51%. Comparing base (e60c518) to head (297dca2).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/utils.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #68       +/-   ##
===========================================
- Coverage   92.95%   52.51%   -40.44%     
===========================================
  Files           6       10        +4     
  Lines         142      278      +136     
===========================================
+ Hits          132      146       +14     
- Misses         10      132      +122     
Flag Coverage Δ
Pkg.test 52.51% <71.42%> (-40.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
Copy link
Author

svchb commented Feb 5, 2026

@vchuravy This fixes the issue we are having with Julia 1.12 in TrixiParticles

@vchuravy vchuravy changed the title Issue 65 llvmcall opaque pointers Feb 5, 2026
@svchb
Copy link
Author

svchb commented Feb 12, 2026

@vchuravy Can you please consider this?

@svchb
Copy link
Author

svchb commented Feb 24, 2026

@vchuravy How are things looking?

Comment on lines +33 to +37
if isdefined(Core.Intrinsics, :atomic_pointermodify)
Core.Intrinsics.atomic_pointermodify(ptr, op, x, base_ordering(ord))
else
UnsafeAtomics.modify!(ptr, op, x, ord)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong and likely doesn't work on non-CPU backends. We do need to fix this in UnsafeAtomics.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the fact UnsafeAtomics has not been updated for 9 years i guess the dependency should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants