Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
===========================================
- Coverage 92.95% 52.51% -40.44%
===========================================
Files 6 10 +4
Lines 142 278 +136
===========================================
+ Hits 132 146 +14
- Misses 10 132 +122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@vchuravy This fixes the issue we are having with Julia 1.12 in TrixiParticles |
|
@vchuravy Can you please consider this? |
|
@vchuravy How are things looking? |
| if isdefined(Core.Intrinsics, :atomic_pointermodify) | ||
| Core.Intrinsics.atomic_pointermodify(ptr, op, x, base_ordering(ord)) | ||
| else | ||
| UnsafeAtomics.modify!(ptr, op, x, ord) | ||
| end |
There was a problem hiding this comment.
This seems wrong and likely doesn't work on non-CPU backends. We do need to fix this in UnsafeAtomics.
There was a problem hiding this comment.
based on the fact UnsafeAtomics has not been updated for 9 years i guess the dependency should be removed.
Fix issue #65