Fix tests #448
Merged
Fix tests #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
commented
Jul 2, 2024
| @@ -314,7 +314,8 @@ function ParseStream(text::AbstractString, index::Integer=1; version=VERSION) | |||
| end | |||
|
|
|||
| # IO-based cases | |||
| function ParseStream(io::IOBuffer; version=VERSION) | |||
| # TODO: switch ParseStream to use a Memory internally on newer versions of Julia | |||
| VERSION < v"1.11.0-DEV.753" && function ParseStream(io::IOBuffer; version=VERSION) | |||
There was a problem hiding this comment.
This special case is not valid on new Julias where the internal io.data field is not a Vector.
|
Thanks for fixing this 💕 |
c42f
pushed a commit
that referenced
this pull request
Jul 21, 2024
* Don't assume (io::IOBuffer).data is a Vector on new versions of Julia * Exclude test/subtype.jl from corpus due to new dependence on where precedence (#395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A where {T} == Zparsing inconsistency with flisp parser #395)