[Auditor] Remove libtool *.la files (#1105)

* [Auditor] Remove libtool *.la files

* Add autotools build system for libfoo, test with it

Author: fingolfin

src/Auditor.jl

@@ -184,6 +184,19 @@ function audit(prefix::Prefix, src_name::AbstractString = "";
         all_ok &= symlink_soname_lib(f; verbose=verbose, autofix=autofix)
     end
 
+    # remove *.la files generated by GNU libtool
+    la_files = collect_files(prefix, endswith(".la"))
+    for f in la_files
+        # sanity check: first byte should be '#', first line should contain 'libtool'
+        line = readline(f)
+        if length(line) == 0 || line[1] != '#' || !occursin("libtool", line)
+            continue
+        end
+        # remove it
+        @info("removing libtool file $f")
+        rm(f; force=true)
+    end
+
     if Sys.iswindows(platform)
         # We also cannot allow any symlinks in Windows because it requires
         # Admin privileges to create them.  Orz

test/auditing.jl

@@ -281,6 +281,42 @@ end
 end
 
 
+@testset "Auditor - .la removal" begin
+    for os in ["linux", "macos", "freebsd", "windows"]
+        platform = Platform("x86_64", os)
+        mktempdir() do build_path
+            build_output_meta = nothing
+            @test_logs (:info, r"removing libtool file .*/destdir/lib/libfoo.la$") match_mode=:any begin
+                build_output_meta = autobuild(
+                    build_path,
+                    "libfoo",
+                    v"1.0.0",
+                    # Copy in the libfoo sources
+                    [DirectorySource(build_tests_dir)],
+                    # Build libfoo using autotools to create a real .la file,
+                    # and also create a fake .la file (which should not be removed)
+                    libfoo_autotools_script * "\ntouch \${prefix}/lib/libbar.la",
+                    # Build for our platform
+                    [platform],
+                    # The products we expect to be build
+                    libfoo_products,
+                    # No dependencies
+                    Dependency[]
+                )
+            end
+
+            @test haskey(build_output_meta, platform)
+            tarball_path, tarball_hash = build_output_meta[platform][1:2]
+            @test isfile(tarball_path)
+
+            # Test that `libfoo.la` has been removed but `libbar.la` hasn't
+            contents = list_tarball_files(tarball_path)
+            @test "lib/libbar.la" in contents
+            @test !("lib/libfoo.la" in contents)
+        end
+    end
+end
+
 @testset "Auditor - .dll moving" begin
     for platform in [Platform("x86_64", "windows")]
         mktempdir() do build_path

test/build_tests/libfoo/Makefile.am

@@ -0,0 +1,9 @@
+ACLOCAL_AMFLAGS = -I m4
+
+lib_LTLIBRARIES = libfoo.la
+libfoo_la_SOURCES = libfoo.c
+libfoo_la_LDFLAGS = -no-undefined
+
+bin_PROGRAMS = fooifier
+fooifier_SOURCES = fooifier.cpp
+fooifier_LDADD = libfoo.la

test/build_tests/libfoo/configure.ac

@@ -0,0 +1,18 @@
+AC_PREREQ([2.69])
+AC_INIT([libfoo], [1.0])
+AC_CONFIG_MACRO_DIRS([m4])
+
+AM_INIT_AUTOMAKE([-Wall -Werror foreign])
+
+AM_PROG_AR
+
+LT_PREREQ([2.4.6])
+LT_INIT([dlopen])
+
+#AC_CANONICAL_TARGET
+
+AC_PROG_CC
+AC_PROG_CXX
+
+AC_CONFIG_FILES([Makefile])
+AC_OUTPUT

test/runtests.jl

@@ -57,6 +57,14 @@ fi
 install_license ${WORKSPACE}/srcdir/libfoo/LICENSE.md
 """
 
+libfoo_autotools_script = raw"""
+cd ${WORKSPACE}/srcdir/libfoo
+autoreconf -fiv
+./configure --prefix=${prefix} --build=${MACHTYPE} --host=${target} --disable-static
+make install
+install_license ${WORKSPACE}/srcdir/libfoo/LICENSE.md
+"""
+
 # Run all our tests
 include("basic.jl")
 include("building.jl")