Disallow running gerald when run against main or master. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
lillialexis
reviewed
May 7, 2025
| // NOTE: We don't want to run Gerald when we're merging a PR into | ||
| // master or main, as this is likely a deploy branch that only contains | ||
| // landed PRs that have already been reviewed. | ||
| const IGNORED_PR_REFS = ['master', 'main']; |
Contributor
There was a problem hiding this comment.
I don't think we want to do this here, since many repos do land straight to main / master. Instead, we can control this repo-by-repo with their own yaml files that call Gerald.
lillialexis
suggested changes
May 7, 2025
Contributor
lillialexis
left a comment
lillialexis
left a comment
There was a problem hiding this comment.
Isn't this better to do in each repo's yaml file? I really do want Gerald to add the github-actions team to all of my OLC changes, for example, many/most of which target main.
Member
Author
|
Ah, so updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We don't want Gerald to run when making a PR against main/master - as we're typically using a merge queue in this scenario and don't want the double-review.
Issue: FEI-6249
Test plan: