Commit 5899cbe
authored
[๐ฅAUDIT๐ฅ] Fix ngettext not returning plural translations. (#2371)
๐ _This is an audit!_ ๐
## Summary:
This bug is in prod right now, unfortunately. Some strings are appearing untranslated.
Issue: FEI-6007
## Test plan:
This was actually wrong in the tests!! So I fixed the test in the process.
Author: jeresig
Auditors: #frontend-infra-web, #wonder-blocks
Required Reviewers:
Approved By:
Checks: โ
Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), โ
Test / Test (ubuntu-latest, 20.x, 2/2), โ
Test / Test (ubuntu-latest, 20.x, 1/2), โ
Lint / Lint (ubuntu-latest, 20.x), โ
Check build sizes (ubuntu-latest, 20.x), โ
Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), โ
Publish npm snapshot (ubuntu-latest, 20.x), โญ๏ธ Chromatic - Skip on Release PR (changesets), โ
Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), โญ๏ธ dependabot, โ
Check for .changeset entries for all changed files (ubuntu-latest, 20.x), โ
gerald
Pull Request URL: #23711 parent b5cad0b commit 5899cbe
File tree
3 files changed
+7
-2
lines changed- .changeset
- packages/wonder-blocks-i18n/src/functions
- __tests__
3 files changed
+7
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
| 142 | + | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
| 213 | + | |
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
| |||
0 commit comments