Skip to content

Commit 6866cd9

Browse files
committed
Add PHP 8.4 Compatibility
1 parent 86fa27a commit 6866cd9

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
strategy:
2424
fail-fast: false
2525
matrix:
26-
php-versions: [ '8.0', '8.1', '8.2', '8.3' ]
26+
php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
2727

2828
# Steps to install, configure and run tests
2929
steps:

src/ConvertKit_API_Traits.php

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public function get_email_stats()
137137
*
138138
* @return false|mixed
139139
*/
140-
public function get_growth_stats(\DateTime $starting = null, \DateTime $ending = null)
140+
public function get_growth_stats(\DateTime|null $starting = null, \DateTime|null $ending = null)
141141
{
142142
return $this->get(
143143
'account/growth_stats',
@@ -326,10 +326,10 @@ public function add_subscriber_to_form(int $form_id, int $subscriber_id, string
326326
public function get_form_subscriptions(
327327
int $form_id,
328328
string $subscriber_state = 'active',
329-
\DateTime $created_after = null,
330-
\DateTime $created_before = null,
331-
\DateTime $added_after = null,
332-
\DateTime $added_before = null,
329+
\DateTime|null $created_after = null,
330+
\DateTime|null $created_before = null,
331+
\DateTime|null $added_after = null,
332+
\DateTime|null $added_before = null,
333333
bool $include_total_count = false,
334334
string $after_cursor = '',
335335
string $before_cursor = '',
@@ -453,10 +453,10 @@ public function add_subscriber_to_sequence(int $sequence_id, int $subscriber_id)
453453
public function get_sequence_subscriptions(
454454
int $sequence_id,
455455
string $subscriber_state = 'active',
456-
\DateTime $created_after = null,
457-
\DateTime $created_before = null,
458-
\DateTime $added_after = null,
459-
\DateTime $added_before = null,
456+
\DateTime|null $created_after = null,
457+
\DateTime|null $created_before = null,
458+
\DateTime|null $added_after = null,
459+
\DateTime|null $added_before = null,
460460
bool $include_total_count = false,
461461
string $after_cursor = '',
462462
string $before_cursor = '',
@@ -669,10 +669,10 @@ public function remove_tag_from_subscriber_by_email(int $tag_id, string $email_a
669669
public function get_tag_subscriptions(
670670
int $tag_id,
671671
string $subscriber_state = 'active',
672-
\DateTime $created_after = null,
673-
\DateTime $created_before = null,
674-
\DateTime $tagged_after = null,
675-
\DateTime $tagged_before = null,
672+
\DateTime|null $created_after = null,
673+
\DateTime|null $created_before = null,
674+
\DateTime|null $tagged_after = null,
675+
\DateTime|null $tagged_before = null,
676676
bool $include_total_count = false,
677677
string $after_cursor = '',
678678
string $before_cursor = '',
@@ -768,10 +768,10 @@ public function get_email_templates(
768768
public function get_subscribers(
769769
string $subscriber_state = 'active',
770770
string $email_address = '',
771-
\DateTime $created_after = null,
772-
\DateTime $created_before = null,
773-
\DateTime $updated_after = null,
774-
\DateTime $updated_before = null,
771+
\DateTime|null $created_after = null,
772+
\DateTime|null $created_before = null,
773+
\DateTime|null $updated_after = null,
774+
\DateTime|null $updated_before = null,
775775
string $sort_field = 'id',
776776
string $sort_order = 'desc',
777777
bool $include_total_count = false,
@@ -1115,8 +1115,8 @@ public function create_broadcast(
11151115
string $content = '',
11161116
string $description = '',
11171117
bool $public = false,
1118-
\DateTime $published_at = null,
1119-
\DateTime $send_at = null,
1118+
\DateTime|null $published_at = null,
1119+
\DateTime|null $send_at = null,
11201120
string $email_address = '',
11211121
string $email_template_id = '',
11221122
string $thumbnail_alt = '',
@@ -1223,8 +1223,8 @@ public function update_broadcast(
12231223
string $content = '',
12241224
string $description = '',
12251225
bool $public = false,
1226-
\DateTime $published_at = null,
1227-
\DateTime $send_at = null,
1226+
\DateTime|null $published_at = null,
1227+
\DateTime|null $send_at = null,
12281228
string $email_address = '',
12291229
string $email_template_id = '',
12301230
string $thumbnail_alt = '',
@@ -1606,14 +1606,14 @@ public function create_purchase(
16061606
string $transaction_id,
16071607
array $products,
16081608
string $currency = 'USD',
1609-
string $first_name = null,
1610-
string $status = null,
1609+
string|null $first_name = null,
1610+
string|null $status = null,
16111611
float $subtotal = 0,
16121612
float $tax = 0,
16131613
float $shipping = 0,
16141614
float $discount = 0,
16151615
float $total = 0,
1616-
\DateTime $transaction_time = null
1616+
\DateTime|null $transaction_time = null
16171617
) {
16181618
// Build parameters.
16191619
$options = [

0 commit comments

Comments
 (0)