From c7f51f3b184f340759ae744aff3b2ddb6fb7d31a Mon Sep 17 00:00:00 2001
From: Tim Carr <tim@n7studios.co.uk>
Date: Mon, 6 Mar 2023 16:48:31 +0000
Subject: [PATCH] Replace check_if_subscriber_in_array()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This is no longer needed, as we query the API by `email_address`, so inspecting the response’s `total_subscribers` is sufficient.
---
 src/ConvertKit_API.php | 34 +++++-----------------------------
 1 file changed, 5 insertions(+), 29 deletions(-)

diff --git a/src/ConvertKit_API.php b/src/ConvertKit_API.php
index a816750..3300895 100644
--- a/src/ConvertKit_API.php
+++ b/src/ConvertKit_API.php
@@ -438,15 +438,13 @@ public function get_subscriber_id(string $email_address)
             return false;
         }
 
-        $subscriber_id = $this::check_if_subscriber_in_array($email_address, $subscribers->subscribers);
-
-        if ($subscriber_id) {
-            return $subscriber_id;
+        if ($subscribers->total_subscribers === 0) {
+            $this->create_log('No subscribers');
+            return false;
         }
 
-        $this->create_log('Subscriber not found');
-
-        return false;
+        // Return the subscriber's ID.
+        return $subscribers->subscribers[0]->id;
     }
 
 
@@ -761,26 +759,4 @@ public function make_request(string $endpoint, string $method, array $args = [])
         $this->create_log('Failed to finish request.');
         return false;
     }
-
-
-    /**
-     * Looks for subscriber with email in array
-     *
-     * @param string $email_address Email Address.
-     * @param array  $subscribers   Subscribers.
-     *
-     * @return false|integer  false if not found, else subscriber object
-     */
-    private function check_if_subscriber_in_array(string $email_address, array $subscribers)
-    {
-        foreach ($subscribers as $subscriber) {
-            if ($subscriber->email_address === $email_address) {
-                $this->create_log('Subscriber found!');
-                return $subscriber->id;
-            }
-        }
-
-        $this->create_log('Subscriber not found on current page.');
-        return false;
-    }
 }