Skip to content

Commit e2ebb1f

Browse files
authored
Merge pull request #37 from ConvertKit/v4-api-methods
v4 API: Use Traits from PHP SDK
2 parents 9a5c6a0 + cc3778d commit e2ebb1f

File tree

9 files changed

+2561
-1366
lines changed

9 files changed

+2561
-1366
lines changed

.env.dist.testing

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ TEST_TABLE_PREFIX=wp_
1616
TEST_SITE_WP_URL=http://127.0.0.1
1717
TEST_SITE_WP_DOMAIN=127.0.0.1
1818
19+
CONVERTKIT_API_BROADCAST_ID="8697158"
1920
CONVERTKIT_API_FORM_ID="2765139"
2021
CONVERTKIT_API_LEGACY_FORM_ID="470099"
2122
CONVERTKIT_API_LANDING_PAGE_ID="2765196"

.env.example

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,15 @@ TEST_TABLE_PREFIX=wp_
1616
TEST_SITE_WP_URL=http://convertkit.local
1717
TEST_SITE_WP_DOMAIN=convertkit.local
1818
TEST_SITE_ADMIN_EMAIL=[email protected]
19+
CONVERTKIT_API_KEY=
20+
CONVERTKIT_API_SECRET=
1921
CONVERTKIT_OAUTH_ACCESS_TOKEN=
2022
CONVERTKIT_OAUTH_REFRESH_TOKEN=
2123
CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA=
2224
CONVERTKIT_OAUTH_REFRESH_TOKEN_NO_DATA=
2325
CONVERTKIT_OAUTH_CLIENT_ID=
2426
CONVERTKIT_OAUTH_REDIRECT_URI=
27+
CONVERTKIT_API_BROADCAST_ID="8697158"
2528
CONVERTKIT_API_FORM_ID="2765139"
2629
CONVERTKIT_API_LEGACY_FORM_ID="470099"
2730
CONVERTKIT_API_LANDING_PAGE_ID="2765196"

.github/workflows/tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ jobs:
3131
DB_PASS: root
3232
DB_HOST: localhost
3333
INSTALL_PLUGINS: "woocommerce" # Don't include this repository's Plugin here.
34+
CONVERTKIT_API_KEY: ${{ secrets.CONVERTKIT_API_KEY }}
35+
CONVERTKIT_API_SECRET: ${{ secrets.CONVERTKIT_API_SECRET }}
3436
CONVERTKIT_OAUTH_ACCESS_TOKEN: ${{ secrets.CONVERTKIT_OAUTH_ACCESS_TOKEN }}
3537
CONVERTKIT_OAUTH_REFRESH_TOKEN: ${{ secrets.CONVERTKIT_OAUTH_REFRESH_TOKEN }}
3638
CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA: ${{ secrets.CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA }}
@@ -111,6 +113,8 @@ jobs:
111113
path: ${{ env.PLUGIN_DIR }}/.env.dist.testing
112114
contents: |
113115
116+
CONVERTKIT_API_KEY=${{ env.CONVERTKIT_API_KEY }}
117+
CONVERTKIT_API_SECRET=${{ env.CONVERTKIT_API_SECRET }}
114118
CONVERTKIT_OAUTH_ACCESS_TOKEN=${{ env.CONVERTKIT_OAUTH_ACCESS_TOKEN }}
115119
CONVERTKIT_OAUTH_REFRESH_TOKEN=${{ env.CONVERTKIT_OAUTH_REFRESH_TOKEN }}
116120
CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA=${{ env.CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA }}

phpcs.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
<!-- Exclude minified Javascript files. -->
1212
<exclude-pattern>*.min.js</exclude-pattern>
1313

14+
<!-- Exclude traits from the PHP SDK. -->
15+
<exclude-pattern>class-convertkit-api-traits.php</exclude-pattern>
16+
1417
<!-- Check that code meets WordPress-Extra standards. -->
1518
<rule ref="WordPress-Extra">
1619
<!--

0 commit comments

Comments
 (0)