Skip to content

Commit d6fcb87

Browse files
authored
Handle invalid enum update properly
1 parent d67624e commit d6fcb87

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

labelbox/schema/data_row_metadata.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ def _parse_ontology(raw_ontology) -> List[DataRowMetadataSchema]:
255255
options = []
256256
for option in schema["options"]:
257257
option["uid"] = option["id"]
258-
259258
options.append(
260259
DataRowMetadataSchema(**{
261260
**option,
@@ -366,7 +365,12 @@ def update_enum_option(self, name: str, option: str,
366365
raise ValueError(
367366
f"Updating Enum option is only supported for Enum metadata schema"
368367
)
368+
valid_options: List[str] = [o.name for o in schema.options]
369369

370+
if option not in valid_options:
371+
raise ValueError(
372+
f"Enum option '{option}' is not a valid option for Enum '{name}', valid options are: {valid_options}"
373+
)
370374
upsert_schema = _UpsertCustomMetadataSchemaInput(id=schema.uid,
371375
name=schema.name,
372376
kind=schema.kind.value)

0 commit comments

Comments
 (0)