Skip to content

Commit d113418

Browse files
Lazarus535Lazarus535
committed
Fixed the two requested changes. 1) Deleting the file "pull_request_template.md" 2) Declaring functions in tests, instead of defining
1 parent 5a87a94 commit d113418

6 files changed

+32
-109
lines changed

‎pull_request_template.md

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎tests/baselines/reference/optionalParameterInDestructuringWithInitializer.errors.txt

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts(31,8): e
88
Type 'undefined' is not assignable to type 'number'.
99
tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts(45,10): error TS2345: Argument of type 'number | undefined' is not assignable to parameter of type 'number'.
1010
Type 'undefined' is not assignable to type 'number'.
11-
tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts(55,11): error TS2345: Argument of type 'number | null' is not assignable to parameter of type 'number | undefined'.
11+
tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts(53,11): error TS2345: Argument of type 'number | null' is not assignable to parameter of type 'number | undefined'.
1212
Type 'null' is not assignable to type 'number | undefined'.
1313

1414

1515
==== tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts (6 errors) ====
1616
// https://github.com/Microsoft/TypeScript/issues/17080
17-
function f(a:number,b:number) {
18-
}
17+
18+
declare function f(a:number,b:number): void;
1919

2020
function func1( {a, b}: {a: number, b?: number} = {a: 1, b: 2} ) {
2121
f(a, b)
@@ -75,9 +75,7 @@ tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts(55,11):
7575
!!! error TS2345: Type 'undefined' is not assignable to type 'number'.
7676
}
7777

78-
function useBar(bar: number) {
79-
f(bar, 1)
80-
}
78+
declare function useBar(bar: number): void;
8179

8280
performFoo();
8381

@@ -88,11 +86,7 @@ tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts(55,11):
8886
!!! error TS2345: Type 'null' is not assignable to type 'number | undefined'.
8987
}
9088

91-
function useBar2(bar: number | undefined) {
92-
if (bar) {
93-
f(bar, 1)
94-
}
95-
}
89+
declare function useBar2(bar: number | undefined): void;
9690

9791
performFoo2();
9892

‎tests/baselines/reference/optionalParameterInDestructuringWithInitializer.js

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//// [optionalParameterInDestructuringWithInitializer.ts]
22
// https://github.com/Microsoft/TypeScript/issues/17080
3-
function f(a:number,b:number) {
4-
}
3+
4+
declare function f(a:number,b:number): void;
55

66
function func1( {a, b}: {a: number, b?: number} = {a: 1, b: 2} ) {
77
f(a, b)
@@ -46,29 +46,21 @@ function performFoo({ bar }: Foo = {}) {
4646
useBar(bar);
4747
}
4848

49-
function useBar(bar: number) {
50-
f(bar, 1)
51-
}
49+
declare function useBar(bar: number): void;
5250

5351
performFoo();
5452

5553
function performFoo2({ bar = null }: Foo = {}) {
5654
useBar2(bar);
5755
}
5856

59-
function useBar2(bar: number | undefined) {
60-
if (bar) {
61-
f(bar, 1)
62-
}
63-
}
57+
declare function useBar2(bar: number | undefined): void;
6458

6559
performFoo2();
6660

6761

6862
//// [optionalParameterInDestructuringWithInitializer.js]
6963
// https://github.com/Microsoft/TypeScript/issues/17080
70-
function f(a, b) {
71-
}
7264
function func1(_a) {
7365
var _b = _a === void 0 ? { a: 1, b: 2 } : _a, a = _b.a, b = _b.b;
7466
f(a, b);
@@ -108,17 +100,9 @@ function performFoo(_a) {
108100
var bar = (_a === void 0 ? {} : _a).bar;
109101
useBar(bar);
110102
}
111-
function useBar(bar) {
112-
f(bar, 1);
113-
}
114103
performFoo();
115104
function performFoo2(_a) {
116105
var _b = (_a === void 0 ? {} : _a).bar, bar = _b === void 0 ? null : _b;
117106
useBar2(bar);
118107
}
119-
function useBar2(bar) {
120-
if (bar) {
121-
f(bar, 1);
122-
}
123-
}
124108
performFoo2();

‎tests/baselines/reference/optionalParameterInDestructuringWithInitializer.symbols

Lines changed: 15 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
=== tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts ===
22
// https://github.com/Microsoft/TypeScript/issues/17080
3-
function f(a:number,b:number) {
3+
4+
declare function f(a:number,b:number): void;
45
>f : Symbol(f, Decl(optionalParameterInDestructuringWithInitializer.ts, 0, 0))
5-
>a : Symbol(a, Decl(optionalParameterInDestructuringWithInitializer.ts, 1, 11))
6-
>b : Symbol(b, Decl(optionalParameterInDestructuringWithInitializer.ts, 1, 20))
7-
}
6+
>a : Symbol(a, Decl(optionalParameterInDestructuringWithInitializer.ts, 2, 19))
7+
>b : Symbol(b, Decl(optionalParameterInDestructuringWithInitializer.ts, 2, 28))
88

99
function func1( {a, b}: {a: number, b?: number} = {a: 1, b: 2} ) {
10-
>func1 : Symbol(func1, Decl(optionalParameterInDestructuringWithInitializer.ts, 2, 1))
10+
>func1 : Symbol(func1, Decl(optionalParameterInDestructuringWithInitializer.ts, 2, 44))
1111
>a : Symbol(a, Decl(optionalParameterInDestructuringWithInitializer.ts, 4, 17))
1212
>b : Symbol(b, Decl(optionalParameterInDestructuringWithInitializer.ts, 4, 19))
1313
>a : Symbol(a, Decl(optionalParameterInDestructuringWithInitializer.ts, 4, 25))
@@ -169,41 +169,27 @@ function performFoo({ bar }: Foo = {}) {
169169
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 43, 21))
170170
}
171171

172-
function useBar(bar: number) {
172+
declare function useBar(bar: number): void;
173173
>useBar : Symbol(useBar, Decl(optionalParameterInDestructuringWithInitializer.ts, 45, 1))
174-
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 47, 16))
175-
176-
f(bar, 1)
177-
>f : Symbol(f, Decl(optionalParameterInDestructuringWithInitializer.ts, 0, 0))
178-
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 47, 16))
179-
}
174+
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 47, 24))
180175

181176
performFoo();
182177
>performFoo : Symbol(performFoo, Decl(optionalParameterInDestructuringWithInitializer.ts, 41, 1))
183178

184179
function performFoo2({ bar = null }: Foo = {}) {
185-
>performFoo2 : Symbol(performFoo2, Decl(optionalParameterInDestructuringWithInitializer.ts, 51, 13))
186-
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 53, 22))
180+
>performFoo2 : Symbol(performFoo2, Decl(optionalParameterInDestructuringWithInitializer.ts, 49, 13))
181+
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 51, 22))
187182
>Foo : Symbol(Foo, Decl(optionalParameterInDestructuringWithInitializer.ts, 37, 1))
188183

189184
useBar2(bar);
190-
>useBar2 : Symbol(useBar2, Decl(optionalParameterInDestructuringWithInitializer.ts, 55, 1))
191-
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 53, 22))
185+
>useBar2 : Symbol(useBar2, Decl(optionalParameterInDestructuringWithInitializer.ts, 53, 1))
186+
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 51, 22))
192187
}
193188

194-
function useBar2(bar: number | undefined) {
195-
>useBar2 : Symbol(useBar2, Decl(optionalParameterInDestructuringWithInitializer.ts, 55, 1))
196-
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 57, 17))
197-
198-
if (bar) {
199-
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 57, 17))
200-
201-
f(bar, 1)
202-
>f : Symbol(f, Decl(optionalParameterInDestructuringWithInitializer.ts, 0, 0))
203-
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 57, 17))
204-
}
205-
}
189+
declare function useBar2(bar: number | undefined): void;
190+
>useBar2 : Symbol(useBar2, Decl(optionalParameterInDestructuringWithInitializer.ts, 53, 1))
191+
>bar : Symbol(bar, Decl(optionalParameterInDestructuringWithInitializer.ts, 55, 25))
206192

207193
performFoo2();
208-
>performFoo2 : Symbol(performFoo2, Decl(optionalParameterInDestructuringWithInitializer.ts, 51, 13))
194+
>performFoo2 : Symbol(performFoo2, Decl(optionalParameterInDestructuringWithInitializer.ts, 49, 13))
209195

‎tests/baselines/reference/optionalParameterInDestructuringWithInitializer.types

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
=== tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts ===
22
// https://github.com/Microsoft/TypeScript/issues/17080
3-
function f(a:number,b:number) {
3+
4+
declare function f(a:number,b:number): void;
45
>f : (a: number, b: number) => void
56
>a : number
67
>b : number
7-
}
88

99
function func1( {a, b}: {a: number, b?: number} = {a: 1, b: 2} ) {
1010
>func1 : ({ a, b }?: { a: number; b?: number | undefined; }) => void
@@ -215,17 +215,10 @@ function performFoo({ bar }: Foo = {}) {
215215
>bar : number | undefined
216216
}
217217

218-
function useBar(bar: number) {
218+
declare function useBar(bar: number): void;
219219
>useBar : (bar: number) => void
220220
>bar : number
221221

222-
f(bar, 1)
223-
>f(bar, 1) : void
224-
>f : (a: number, b: number) => void
225-
>bar : number
226-
>1 : 1
227-
}
228-
229222
performFoo();
230223
>performFoo() : void
231224
>performFoo : ({ bar }?: Foo) => void
@@ -243,21 +236,10 @@ function performFoo2({ bar = null }: Foo = {}) {
243236
>bar : number | null
244237
}
245238

246-
function useBar2(bar: number | undefined) {
239+
declare function useBar2(bar: number | undefined): void;
247240
>useBar2 : (bar: number | undefined) => void
248241
>bar : number | undefined
249242

250-
if (bar) {
251-
>bar : number | undefined
252-
253-
f(bar, 1)
254-
>f(bar, 1) : void
255-
>f : (a: number, b: number) => void
256-
>bar : number
257-
>1 : 1
258-
}
259-
}
260-
261243
performFoo2();
262244
>performFoo2() : void
263245
>performFoo2 : ({ bar }?: Foo) => void

‎tests/cases/compiler/optionalParameterInDestructuringWithInitializer.ts

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// @strictNullChecks: true
22
// https://github.com/Microsoft/TypeScript/issues/17080
3-
function f(a:number,b:number) {
4-
}
3+
4+
declare function f(a:number,b:number): void;
55

66
function func1( {a, b}: {a: number, b?: number} = {a: 1, b: 2} ) {
77
f(a, b)
@@ -46,20 +46,14 @@ function performFoo({ bar }: Foo = {}) {
4646
useBar(bar);
4747
}
4848

49-
function useBar(bar: number) {
50-
f(bar, 1)
51-
}
49+
declare function useBar(bar: number): void;
5250

5351
performFoo();
5452

5553
function performFoo2({ bar = null }: Foo = {}) {
5654
useBar2(bar);
5755
}
5856

59-
function useBar2(bar: number | undefined) {
60-
if (bar) {
61-
f(bar, 1)
62-
}
63-
}
57+
declare function useBar2(bar: number | undefined): void;
6458

6559
performFoo2();

0 commit comments

Comments
 (0)