Handle edge case of empty bounds on _getBoundsCenterZoom#5157
Merged
perliedman merged 3 commits intomasterfrom May 11, 2017
Merged
Handle edge case of empty bounds on _getBoundsCenterZoom#5157perliedman merged 3 commits intomasterfrom
perliedman merged 3 commits intomasterfrom
Conversation
perliedman
approved these changes
May 11, 2017
Member
perliedman
left a comment
perliedman
left a comment
There was a problem hiding this comment.
This must be one of the narrowest (figuratively as well as literally ;)) use cases I've seen, but 👍 FIX ALL THE THINGS!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5153.
Lacking unit tests right now, should be able to whip up one.There's a unit test, and I've made sure that it fails without the fix.