feat(Dashboards): Switches to grid view (LL-287 & LLC-15) #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladislav-999
requested review from
PrinceWaune,
crazy-grizzly and
lydiamross
lydiamross
requested changes
Mar 9, 2020
Contributor
lydiamross
left a comment
lydiamross
left a comment
There was a problem hiding this comment.
This looks great, Ian and Ollie have both had a look at it too and are really happy with it.
The privateIcon on the grid view is going to be tested by users because we're not sure that it currently has the expected experience, but it doesn't need to change here in this pr.
There are just a couple of small changes
lydiamross
approved these changes
Mar 10, 2020
ryasmi
changed the title
ryasmi
changed the title
lydiamross
reviewed
Apr 6, 2020
lydiamross
reviewed
Apr 6, 2020
crazy-grizzly
approved these changes
Apr 21, 2020
Member
|
🎉 This PR is included in version 6.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learningpool.atlassian.net/browse/LLC-15
https://learningpool.atlassian.net/browse/LL-287