Bugfix/auto normalizing logits binary#3377
Conversation
|
Hi @SkafteNicki @justusschock @Borda did you have a moment to take a lot the PR? I totally get it if you're busy, but if possible would very much appreciate it if you let me know when you could get around to a review! Have a great week! ☀️ |
|
Hi again @SkafteNicki @justusschock @Borda any chance you might be able to do a review for this fix anytime soon? I'd love to make suitable fixes for the other metrics as soon as we merge this one. |
|
I checked the maintainer list over at https://lightning.ai/docs/torchmetrics/stable/governance.html , so I'm moving my question to the currently listed maintainers. Hi @rittik9 @baskrahmer @matsumotosan , could you checkout this PR? I firmly believe that It would be a great addition to the library, as this bug is quite difficult to discover by oneself and as such could have silent impact on peoples workflows. Have amazing days! ☀️ |
What does this PR do?
Fixes #1604 for binary metrics
Details
PR review
The bug has been discussed a lot up to this point. I've decided to tackle it in parts, as merging the entire thing at one would be challenging. This PR fixes the behaviour in binary metrics. When we decide on the final nature of the fix and merge it, I will tackle the other ones.
Did you have fun?
Make sure you had fun coding 🙃
A LOT OF FUN, the day of the end of this vengeful bug draws nearer
Credit to @SkafteNicki who began the work on this bug and whose code this PR was heavily based on