skipgen: Change default behavior to show all skips

When running skipgen against a yaml skipfile with no additional
arguments, return all of the skips. Additional arguments
(board/environment/branch) can be used to narrow down the list.

The previous behavior would only show skips that are "all/all/all" when
run with no arguments, and then more skips would be returned as
board/environment/branch was added.

Signed-off-by: Dan Rue <dan.rue@linaro.org>

Author: danrue

Makefile

@@ -9,7 +9,7 @@ help:
 	@echo "     test"
 	@echo "     clean"
 
-$(FILE): test
+$(FILE): test skipgen.go
 	go build
 
 test:

README.md

@@ -17,9 +17,9 @@ binary.
 
 ## Example Usage
 
+Show all skips available:
+
     $ skipgen examples/skipfile.yaml
-    seccomp_bpf
-    $ skipgen --board x15 --environment production --branch=4.4 examples/skipfile.yaml
     test_verifier
     test_tag
     test_maps
@@ -29,6 +29,12 @@ binary.
     test_align
     ...
 
+Show skips that apply to the x15 board in the production environment and branch 4.4:
+
+    ./skipgen --board=x15 --environment=staging --branch=4.4 examples/skipfile.yaml 
+    run_vmtests
+    seccomp_bpf
+
 ## Skipfile Format
 
 See [examples/skipfile.yaml](examples/skipfile.yaml).

examples/skipfile.yaml

@@ -3,7 +3,6 @@ skiplist:
     url: https://projects.linaro.org/projects/CTT/queues/issue/CTT-585
     environments:
       - production
-      - staging
     boards:
       - all
     branches:

skipgen.go

@@ -46,6 +46,9 @@ func (a *StringArray) UnmarshalYAML(unmarshal func(interface{}) error) error {
 // in a slice of strings. If "all" is contained in
 // the slice, then true is always returned.
 func stringInSlice(a string, list []string) bool {
+	if a == "all" {
+		return true
+	}
 	for _, b := range list {
 		if b == a || b == "all" {
 			return true
@@ -98,9 +101,9 @@ func usage() {
 
 func main() {
 
-	boardPtr := flag.String("board", "all", "Board name. If not specified, skips that apply to all boards will be returned.")
-	branchPtr := flag.String("branch", "all", "Branch name. If not specified, skips that apply to all branches will be returned.")
-	environmentPtr := flag.String("environment", "all", "Environment name. If not specified, skips that apply to all environments will be returned.")
+	boardPtr := flag.String("board", "all", "Board name. If not specified, skips for all boards will be returned.")
+	branchPtr := flag.String("branch", "all", "Branch name. If not specified, skips for all branches will be returned.")
+	environmentPtr := flag.String("environment", "all", "Environment name. If not specified, skips for all environments will be returned.")
 	versionPtr := flag.Bool("version", false, "Print skipgen version and exit.")
 	flag.Parse()