Skip to content

Conversation

@wbruna
Copy link

@wbruna wbruna commented Nov 30, 2025

Almost no code conflicts on this one.

I had to add new wrappers on model.cpp to load the new Mistral vocabulary and merges. I don't really have the hardware to test Flux.2, though, so I didn't try to include the matching .embd files.

Qwen loading is broken, probably due to the qwen2vl -> llm replacement. I'll see if I can fix it.

@wbruna
Copy link
Author

wbruna commented Nov 30, 2025

I didn't hit other obvious bugs, so I think this is ready for review.

@wbruna wbruna marked this pull request as ready for review November 30, 2025 12:12
@LostRuins
Copy link
Owner

Qwen loading is broken, probably due to the qwen2vl -> llm replacement

wait what happened? didn't notice they touched qwen

@wbruna
Copy link
Author

wbruna commented Nov 30, 2025

wait what happened? didn't notice they touched qwen

qwen2vl was generalized to llm all around. It didn't cause a build failure on Koboldcpp, but the loaded qwen2vl tensor prefix changed from "text_encoder.qwen2vl." to "text_encoder.llm." (look for "text_encoders." on leejet/stable-diffusion.cpp@52b67c5), so our clip -> qwen replacement didn't work anymore.

@wbruna
Copy link
Author

wbruna commented Dec 1, 2025

I'll work on it in a few hours.

By the way, leejet just merged the Z-Image-Turbo support. Shall I include it here, or on a follow-up PR? (the only problem with a separate PR would be the fix for Flux.2 VAE tiling, but I can include it first).

@LostRuins
Copy link
Owner

We can combine them I think. At most we can do the same approach we did previously where we eventually squash it into two commits and I do a merge

@wbruna wbruna force-pushed the kcpp_sd_update_202511_2 branch from 93f541a to 53407c8 Compare December 1, 2025 20:33
@wbruna wbruna changed the title sd: sync to master-383-20eb674 sd: sync to master-387-e4c50f1 Dec 1, 2025
@wbruna
Copy link
Author

wbruna commented Dec 1, 2025

186111-z-image-turbo-kcpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants