Skip to content

Commit d9d568f

Browse files
committed
fix: Incorrect typing for kwargs
1 parent 5bbe15f commit d9d568f

File tree

2 files changed

+94
-90
lines changed

2 files changed

+94
-90
lines changed

pymisp/abstract.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def misp_objects_path(self, misp_objects_path: str | Path) -> None:
141141
misp_objects_path = Path(misp_objects_path)
142142
self.__misp_objects_path = misp_objects_path
143143

144-
def from_dict(self, **kwargs) -> None: # type: ignore[no-untyped-def]
144+
def from_dict(self, **kwargs: Any) -> None:
145145
"""Loading all the parameters as class properties, if they aren't `None`.
146146
This method aims to be called when all the properties requiring a special
147147
treatment are processed.
@@ -154,15 +154,15 @@ def from_dict(self, **kwargs) -> None: # type: ignore[no-untyped-def]
154154
# We load an existing dictionary, marking it an not-edited
155155
self.__edited = False
156156

157-
def update_not_jsonable(self, *args) -> None: # type: ignore[no-untyped-def]
157+
def update_not_jsonable(self, *args: Any) -> None:
158158
"""Add entries to the __not_jsonable list"""
159159
self.__not_jsonable += args
160160

161161
def set_not_jsonable(self, args: list[str]) -> None:
162162
"""Set __not_jsonable to a new list"""
163163
self.__not_jsonable = args
164164

165-
def _remove_from_not_jsonable(self, *args) -> None: # type: ignore[no-untyped-def]
165+
def _remove_from_not_jsonable(self, *args: Any) -> None:
166166
"""Remove the entries that are in the __not_jsonable list"""
167167
for entry in args:
168168
try:
@@ -331,7 +331,7 @@ def _datetime_to_timestamp(self, d: int | float | str | datetime) -> int:
331331
return int(d)
332332
return int(d.timestamp())
333333

334-
def _add_tag(self, tag: str | MISPTag | Mapping[str, Any] | None = None, **kwargs): # type: ignore[no-untyped-def]
334+
def _add_tag(self, tag: str | MISPTag | Mapping[str, Any] | None = None, **kwargs: Any): # type: ignore[no-untyped-def]
335335
"""Add a tag to the attribute (by name or a MISPTag object)"""
336336
if isinstance(tag, str):
337337
misp_tag = MISPTag()
@@ -374,7 +374,7 @@ class MISPTag(AbstractMISP):
374374

375375
_fields_for_feed: set[str] = {'name', 'colour', 'relationship_type', 'local'}
376376

377-
def __init__(self, force_timestamps: bool=False, **kwargs) -> None: # type: ignore[no-untyped-def]
377+
def __init__(self, force_timestamps: bool=False, **kwargs: Any) -> None:
378378
super().__init__(force_timestamps)
379379
self.name: str
380380
self.exportable: bool
@@ -384,7 +384,7 @@ def __init__(self, force_timestamps: bool=False, **kwargs) -> None: # type: ign
384384
if kwargs:
385385
self.from_dict(**kwargs)
386386

387-
def from_dict(self, **kwargs) -> None: # type: ignore[no-untyped-def]
387+
def from_dict(self, **kwargs: Any) -> None:
388388
if kwargs.get('Tag'):
389389
kwargs = kwargs.get('Tag')
390390
super().from_dict(**kwargs)

0 commit comments

Comments
 (0)