feat: un-prescribe when detection_control_status is OFFICIAL_REPORT_DRAWN_UP

Author: stephenfreelance

core/models/detection_data.py

@@ -79,6 +79,12 @@ class DetectionData(TimestampedModelMixin, UuidModelMixin, DeletableModelMixin):
     def set_detection_control_status(self, value: DetectionControlStatus):
         self.detection_control_status = value
 
+        # un-prescribe when detection_control_status is OFFICIAL_REPORT_DRAWN_UP
+        if value == DetectionControlStatus.OFFICIAL_REPORT_DRAWN_UP:
+            self.detection_prescription_status = (
+                DetectionPrescriptionStatus.NOT_PRESCRIBED
+            )
+
         if (
             value != DetectionControlStatus.NOT_CONTROLLED
             and self.detection_validation_status

core/serializers/detection_data.py

@@ -155,7 +155,7 @@ def update(self, instance: DetectionData, validated_data):
             or instance.detection_control_status
         )
 
-        # allow update official_report_date only if detection_control_status isOFFICIAL_REPORT_DRAWN_UP
+        # allow update official_report_date only if detection_control_status is OFFICIAL_REPORT_DRAWN_UP
         if detection_control_status != DetectionControlStatus.OFFICIAL_REPORT_DRAWN_UP:
             validated_data.pop("official_report_date", None)