chore(poc): retakes

Author: AntoineSmagghe

src/Infrastructure/Adapter/DatexGenerator.php

@@ -8,6 +8,8 @@
 use App\Application\QueryBusInterface;
 use App\Application\Regulation\DatexGeneratorInterface;
 use App\Application\Regulation\Query\GetRegulationOrdersToDatexFormatQuery;
+use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\Filesystem\Path;
 
 final class DatexGenerator implements DatexGeneratorInterface
 {
@@ -17,9 +19,10 @@ public function __construct(
         private \Twig\Environment $twig,
         private DateUtilsInterface $dateUtils,
         private QueryBusInterface $queryBus,
+        private Filesystem $filesystem,
         string $projectDir,
     ) {
-        $this->datexFilePath = $projectDir . '/var/datex/regulations.xml';
+        $this->datexFilePath = Path::join($projectDir, '/var/datex/regulations.xml');
     }
 
     public function generate(): void
@@ -28,10 +31,10 @@ public function generate(): void
             new GetRegulationOrdersToDatexFormatQuery(),
         );
 
-        $dir = \dirname($this->datexFilePath);
+        $dir = Path::getDirectory($this->datexFilePath);
 
-        if (!is_dir($dir)) {
-            mkdir($dir, 0o755, true);
+        if (!$this->filesystem->exists($dir)) {
+            $this->filesystem->mkdir($dir, 0o755);
         }
 
         $tmpFile = $this->datexFilePath . '.tmp';
@@ -50,15 +53,15 @@ public function generate(): void
 
         ob_end_flush();
         fclose($handle);
-        rename($tmpFile, $this->datexFilePath);
+        $this->filesystem->rename($tmpFile, $this->datexFilePath, overwrite: true);
     }
 
     public function getCachedDatex(): string
     {
-        if (!file_exists($this->datexFilePath)) {
+        if (!$this->filesystem->exists($this->datexFilePath)) {
             $this->generate();
         }
 
-        return file_get_contents($this->datexFilePath);
+        return $this->filesystem->readFile($this->datexFilePath);
     }
 }

tests/Unit/Infrastructure/Adapter/DatexGeneratorTest.php

@@ -10,6 +10,7 @@
 use App\Infrastructure\Adapter\DatexGenerator;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Filesystem\Filesystem;
 
 final class DatexGeneratorTest extends TestCase
 {
@@ -77,6 +78,7 @@ public function testGenerateCreatesDirectoryAndFile(): void
             $this->twig,
             $this->dateUtils,
             $this->queryBus,
+            new Filesystem(),
             $this->tmpDir,
         );
 
@@ -120,6 +122,7 @@ public function testGenerateOverwritesExistingFile(): void
             $this->twig,
             $this->dateUtils,
             $this->queryBus,
+            new Filesystem(),
             $this->tmpDir,
         );