Stream datex response

Author: mmarchois

src/Infrastructure/Controller/Api/Regulations/GetCifsIncidentsController.php

@@ -8,6 +8,7 @@
 use App\Application\Regulation\Query\GetCifsIncidentsQuery;
 use OpenApi\Attributes as OA;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\Routing\Attribute\Route;
 
 final class GetCifsIncidentsController
@@ -29,10 +30,12 @@ public function __invoke(): Response
     {
         $incidents = $this->queryBus->handle(new GetCifsIncidentsQuery());
 
-        return new Response(
-            $this->twig->render('api/regulations/cifs.xml.twig', [
-                'incidents' => $incidents,
-            ]),
+        return new StreamedResponse(
+            function () use ($incidents): void {
+                $this->twig->display('api/regulations/cifs.xml.twig', [
+                    'incidents' => $incidents,
+                ]);
+            },
             Response::HTTP_OK,
             ['Content-Type' => 'text/xml; charset=UTF-8'],
         );

src/Infrastructure/Controller/Api/Regulations/GetRegulationsController.php

@@ -9,6 +9,7 @@
 use App\Application\Regulation\Query\GetRegulationOrdersToDatexFormatQuery;
 use OpenApi\Attributes as OA;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\HttpKernel\Attribute\MapQueryParameter;
 use Symfony\Component\Routing\Attribute\Route;
 
@@ -44,11 +45,13 @@ public function __invoke(
             ),
         );
 
-        return new Response(
-            $this->twig->render('api/regulations.xml.twig', [
-                'publicationTime' => $this->dateUtils->getNow(),
-                'regulationOrders' => $regulationOrders,
-            ]),
+        return new StreamedResponse(
+            function () use ($regulationOrders): void {
+                $this->twig->display('api/regulations.xml.twig', [
+                    'publicationTime' => $this->dateUtils->getNow(),
+                    'regulationOrders' => $regulationOrders,
+                ]);
+            },
             Response::HTTP_OK,
             ['Content-Type' => 'text/xml; charset=UTF-8'],
         );

tests/Integration/Infrastructure/Controller/Api/GetCifsIncidentsControllerTest.php

@@ -5,6 +5,7 @@
 namespace App\Tests\Integration\Infrastructure\Controller\Api;
 
 use App\Tests\Integration\Infrastructure\Controller\AbstractWebTestCase;
+use Symfony\Component\HttpFoundation\StreamedResponse;
 
 final class GetCifsIncidentsControllerTest extends AbstractWebTestCase
 {
@@ -14,15 +15,17 @@ public function testGet(): void
         $client->request('GET', '/api/regulations/cifs.xml');
         $response = $client->getResponse();
 
+        $this->assertInstanceOf(StreamedResponse::class, $response);
         $this->assertResponseStatusCodeSame(200);
         $this->assertSecurityHeaders();
         $this->assertSame('text/xml; charset=UTF-8', $response->headers->get('content-type'));
 
+        $content = $client->getInternalResponse()->getContent();
         $xml = new \DOMDocument();
-        $xml->loadXML($response->getContent(), \LIBXML_NOBLANKS);
+        $xml->loadXML($content, \LIBXML_NOBLANKS);
         $this->assertXmlStringEqualsXmlFile(
             __DIR__ . '/cifs-incidents-expected-result.xml',
-            $response->getContent(),
+            $content,
         );
         $this->assertTrue($xml->schemaValidate(self::$kernel->getProjectDir() . '/docs/spec/cifs/cifsv2.xsd'));
     }

tests/Integration/Infrastructure/Controller/Api/GetRegulationsControllerTest.php

@@ -10,6 +10,7 @@
 use App\Tests\Integration\Infrastructure\Controller\AbstractWebTestCase;
 use App\Tests\SessionHelper;
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
+use Symfony\Component\HttpFoundation\StreamedResponse;
 
 final class GetRegulationsControllerTest extends AbstractWebTestCase
 {
@@ -44,6 +45,7 @@ public function testGetRegulationsToDatexFormat(): void
         $client->request('GET', '/api/regulations.xml');
         $response = $client->getResponse();
 
+        $this->assertInstanceOf(StreamedResponse::class, $response);
         $this->assertSame('text/xml; charset=UTF-8', $response->headers->get('content-type'));
         $this->assertResponseStatusCodeSame(200);
         $this->assertSecurityHeaders();
@@ -69,6 +71,7 @@ public function testGetRegulationsToDatexFormatWithFilters(): void
         $client->request('GET', '/api/regulations.xml?includePermanent=false&includeTemporary=true&includeExpired=true');
         $response = $client->getResponse();
 
+        $this->assertInstanceOf(StreamedResponse::class, $response);
         $this->assertSame('text/xml; charset=UTF-8', $response->headers->get('content-type'));
         $this->assertResponseStatusCodeSame(200);
         $this->assertSecurityHeaders();

tests/Integration/Infrastructure/Symfony/Command/RunMetabaseExportCommandTest.php

@@ -8,6 +8,9 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\Console\Tester\CommandTester;
 
+/**
+ *  @group only
+ */
 final class RunMetabaseExportCommandTest extends KernelTestCase
 {
     public function testExecute(): void

tests/Mock/DiaLogMockHttpClient.php

@@ -24,6 +24,10 @@ private function handleRequests(string $method, string $url, array $options): Mo
         $request = Request::create($url, $method);
         $response = $this->httpKernel->handle($request);
 
-        return new MockResponse($response->getContent());
+        ob_start();
+        $response->sendContent();
+        $content = ob_get_clean();
+
+        return new MockResponse($content);
     }
 }