io error message in make_tests#58
io error message in make_tests#58colin-kiegel wants to merge 1 commit intoManishearth:masterfrom colin-kiegel:fix/error_message
make_tests#58Conversation
|
Hey @colin-kiegel, sorry for not getting back on this PR sooner. I'm somewhat hesitant to merge a change like this, because this tool is meant to just be an extraction of the same tool in rust-lang/rust. The codebase here hasn't kept up with rust-lang/rust in a while (primarily because no one has asked), but if that happens, then a change like this is likely to get lost. On the other hand, this is pretty trivial, so I'm thinking to merge it and that'll be that. May I suggest you submit this as a PR for rust-lang/rust as well? |
|
Yes, that's ok for me. |
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
I would accept this upstream if you send a PR (https://github.com/rust-lang/rust/blob/4e88b7363b7858960ccfd87326ece9d00bf4d973/src/tools/compiletest/src/main.rs#L544).
We should use expect instead of unwrap. This commit is based on Manishearth/compiletest-rs#58. Thanks to @colin-kiegel.
Improve error message in make_tests We should use expect instead of unwrap. This commit is based on Manishearth/compiletest-rs#58. Thanks to @colin-kiegel.
3 participants
This would have helped me to understand a broken configuration more quickly. I had compiletest set up to look for a couple of directories, but one was missing and it took me a while to figure it out.
PS: The previous error message was generic, something like "Path does not exist".