WIP MDEV-37949: Implement innodb_log_archive, innodb_lsn_archived

The new setting SET GLOBAL innodb_log_archive=ON will enable log
archiving as soon as the current ib_logfile0 is about to wrap around
an odd number of times.

The new status variable innodb_lsn_archived will return 0 when log
archiving is not enabled, or a LSN since when a complete InnoDB log
archive is available.

When innodb_log_archive=ON, the setting SET GLOBAL innodb_log_file_size
will affect subsequently created log files when the file that is being
currently written is running out.

log_t::archive_new_mmap(): Create and memory-map a new log file,
and update file_size to resize_target.

log_t::archive_set_size(): Ensure that resize_target is set for
new archived log files.

mtr_t::finish_writer(): Specialize for innodb_log_archive=ON

TODO: Specialize log_t::resizing_and_latch (non-PMEM code path).

TODO: Rename log files and set innodb_lsn_archived on checkpoint.

TODO: Implement recovery from archived log.

Author: dr-m

mysql-test/suite/innodb/r/innodb_status_variables.result

@@ -51,6 +51,7 @@ INNODB_LOG_WRITES
 INNODB_LSN_CURRENT
 INNODB_LSN_FLUSHED
 INNODB_LSN_LAST_CHECKPOINT
+INNODB_LSN_ARCHIVED
 INNODB_MASTER_THREAD_ACTIVE_LOOPS
 INNODB_MASTER_THREAD_IDLE_LOOPS
 INNODB_MAX_TRX_ID

mysql-test/suite/innodb/r/log_file_size_online.result

@@ -1,3 +1,4 @@
+SET GLOBAL innodb_log_archive=OFF;
 SET GLOBAL innodb_log_file_size=4194304;
 SHOW VARIABLES LIKE 'innodb_log_file_size';
 Variable_name	Value
@@ -11,7 +12,7 @@ a INT PRIMARY KEY AUTO_INCREMENT,
 b CHAR(255) NOT NULL)
 ENGINE=INNODB;
 INSERT INTO t SELECT NULL, REPEAT('a', 255) FROM seq_1_to_20000;
-# restart: --innodb-log-file-size=4194304
+# restart: --innodb-log-file-size=4194304 --skip-innodb-log-archive
 SELECT COUNT(*) FROM t;
 COUNT(*)
 20000
@@ -28,8 +29,15 @@ Got one of the listed errors
 connect con1,localhost,root;
 SET GLOBAL innodb_log_file_size=7340032;
 connection default;
+SET GLOBAL innodb_log_archive=ON;
+SET GLOBAL innodb_log_archive=OFF;
 KILL QUERY @id;
 connection con1;
+SET GLOBAL innodb_log_archive=ON, innodb_log_file_size=10485760;
+SELECT @@GLOBAL.innodb_log_file_size!=10485760;
+@@GLOBAL.innodb_log_file_size!=10485760
+1
+SET GLOBAL innodb_log_archive=OFF;
 connection default;
 SET GLOBAL innodb_log_file_size=5242880;
 connection con1;
@@ -46,6 +54,8 @@ connection con1;
 disconnect con1;
 connection default;
 # restart
+SET @save_archive=@@GLOBAL.innodb_log_archive;
+SET GLOBAL innodb_log_archive=OFF;
 SELECT * FROM t WHERE a<10;
 a	b
 1	
@@ -73,4 +83,5 @@ SHOW VARIABLES LIKE 'innodb_log_file_size';
 Variable_name	Value
 innodb_log_file_size	5242880
 FOUND 1 /InnoDB: Resized log to 6\.000MiB/ in mysqld.1.err
+SET GLOBAL innodb_log_archive=@save_archive;
 DROP TABLE t;

mysql-test/suite/innodb/t/innodb-master.opt

@@ -2,5 +2,3 @@
 --default-storage-engine=MyISAM
 --innodb-strict-mode=0
 --innodb-file-per-table=0
---loose-innodb-track-changed-pages
---loose-innodb-log-archive

mysql-test/suite/innodb/t/log_file_size_online.opt

@@ -0,0 +1 @@
+--skip-innodb-log-archive

mysql-test/suite/innodb/t/log_file_size_online.test

@@ -4,6 +4,13 @@
 
 let SEARCH_FILE = $MYSQLTEST_VARDIR/log/mysqld.1.err;
 
+SET GLOBAL innodb_log_archive=OFF;
+let $wait_condition=
+SELECT variable_value = 0
+FROM information_schema.global_status
+WHERE variable_name = 'innodb_lsn_archived';
+--source include/wait_condition.inc
+
 SET GLOBAL innodb_log_file_size=4194304;
 SHOW VARIABLES LIKE 'innodb_log_file_size';
 SELECT global_value FROM information_schema.system_variables
@@ -16,7 +23,7 @@ ENGINE=INNODB;
 
 INSERT INTO t SELECT NULL, REPEAT('a', 255) FROM seq_1_to_20000;
 
---let $restart_parameters=--innodb-log-file-size=4194304
+--let $restart_parameters=--innodb-log-file-size=4194304 --skip-innodb-log-archive
 --source include/restart_mysqld.inc
 
 SELECT COUNT(*) FROM t;
@@ -41,10 +48,20 @@ let $ID= `SELECT @id := CONNECTION_ID()`;
 send SET GLOBAL innodb_log_file_size=7340032;
 --connection default
 let $ignore= `SELECT @id := $ID`;
+--error 0,ER_WRONG_USAGE
+SET GLOBAL innodb_log_archive=ON;
+SET GLOBAL innodb_log_archive=OFF;
+
 KILL QUERY @id;
 --connection con1
 reap;
 
+# When innodb_log_archive=ON, SET GLOBAL innodb_log_file_size is instantaneous
+# but will not reflect the file size.
+SET GLOBAL innodb_log_archive=ON, innodb_log_file_size=10485760;
+SELECT @@GLOBAL.innodb_log_file_size!=10485760;
+SET GLOBAL innodb_log_archive=OFF;
+
 --connection default
 send SET GLOBAL innodb_log_file_size=5242880;
 
@@ -66,6 +83,14 @@ reap;
 --let $restart_parameters=
 --source include/restart_mysqld.inc
 
+SET @save_archive=@@GLOBAL.innodb_log_archive;
+SET GLOBAL innodb_log_archive=OFF;
+let $wait_condition=
+SELECT variable_value = 0
+FROM information_schema.global_status
+WHERE variable_name = 'innodb_lsn_archived';
+--source include/wait_condition.inc
+
 SELECT * FROM t WHERE a<10;
 SELECT COUNT(*),LENGTH(b) FROM t GROUP BY b;
 
@@ -76,5 +101,6 @@ SET GLOBAL innodb_log_file_size=5242880;
 SHOW VARIABLES LIKE 'innodb_log_file_size';
 let SEARCH_PATTERN = InnoDB: Resized log to 6\\.000MiB;
 --source include/search_pattern_in_file.inc
+SET GLOBAL innodb_log_archive=@save_archive;
 
 DROP TABLE t;

mysql-test/suite/sys_vars/r/sysvars_innodb.result

@@ -932,6 +932,18 @@ NUMERIC_BLOCK_SIZE	0
 ENUM_VALUE_LIST	NULL
 READ_ONLY	NO
 COMMAND_LINE_ARGUMENT	REQUIRED
+VARIABLE_NAME	INNODB_LOG_ARCHIVE
+SESSION_VALUE	NULL
+DEFAULT_VALUE	OFF
+VARIABLE_SCOPE	GLOBAL
+VARIABLE_TYPE	BOOLEAN
+VARIABLE_COMMENT	Whether log archiving is desired (innodb_lsn_archived>0 if enabled)
+NUMERIC_MIN_VALUE	NULL
+NUMERIC_MAX_VALUE	NULL
+NUMERIC_BLOCK_SIZE	NULL
+ENUM_VALUE_LIST	OFF,ON
+READ_ONLY	NO
+COMMAND_LINE_ARGUMENT	OPTIONAL
 VARIABLE_NAME	INNODB_LOG_BUFFER_SIZE
 SESSION_VALUE	NULL
 DEFAULT_VALUE	16777216
@@ -973,7 +985,7 @@ SESSION_VALUE	NULL
 DEFAULT_VALUE	100663296
 VARIABLE_SCOPE	GLOBAL
 VARIABLE_TYPE	BIGINT UNSIGNED
-VARIABLE_COMMENT	Redo log size in bytes.
+VARIABLE_COMMENT	Desired size of ib_logfile0 in bytes
 NUMERIC_MIN_VALUE	4194304
 NUMERIC_MAX_VALUE	18446744073709551615
 NUMERIC_BLOCK_SIZE	4096

sql/upgrade_conf_file.cc

@@ -97,7 +97,6 @@ static const char *removed_variables[] =
 "innodb_locks_unsafe_for_binlog",
 "innodb_log_arch_dir",
 "innodb_log_arch_expire_sec",
-"innodb_log_archive",
 "innodb_log_block_size",
 "innodb_log_checksum_algorithm",
 "innodb_log_checksums",

storage/innobase/handler/ha_innodb.cc

@@ -950,6 +950,7 @@ static SHOW_VAR innodb_status_variables[]= {
   {"lsn_flushed", &export_vars.innodb_lsn_flushed, SHOW_ULONGLONG},
   {"lsn_last_checkpoint", &export_vars.innodb_lsn_last_checkpoint,
    SHOW_ULONGLONG},
+  {"lsn_archived", &log_sys.archived_lsn, SHOW_ULONGLONG},
   {"master_thread_active_loops", &srv_main_active_loops, SHOW_SIZE_T},
   {"master_thread_idle_loops", &srv_main_idle_loops, SHOW_SIZE_T},
   {"max_trx_id", &export_vars.innodb_max_trx_id, SHOW_ULONGLONG},
@@ -19430,6 +19431,34 @@ static MYSQL_SYSVAR_BOOL(data_file_write_through, fil_system.write_through,
   "Whether each write to data files writes through",
   nullptr, innodb_data_file_write_through_update, FALSE);
 
+static void innodb_log_archive_update(THD *, st_mysql_sys_var*,
+                                      void *, const void *save) noexcept
+{
+  const my_bool archive= *static_cast<const my_bool*>(save);
+  log_sys.latch.wr_lock(SRW_LOCK_CALL);
+  const lsn_t resizing{log_sys.resize_in_progress()};
+  if (archive && UNIV_UNLIKELY(resizing != 0))
+    my_printf_error(ER_WRONG_USAGE,
+                    "SET GLOBAL innodb_log_file_size is in progress", MYF(0));
+  else
+  {
+    log_sys.archive= archive;
+    if (!resizing)
+    {
+      if (archive)
+        log_sys.archive_set_size();
+      mtr_t::finisher_update();
+    }
+  }
+  log_sys.archived_lsn= 0; // FIXME: move this to log_t::write_checkpoint()
+  log_sys.latch.wr_unlock();
+}
+
+static MYSQL_SYSVAR_BOOL(log_archive, log_sys.archive,
+  PLUGIN_VAR_OPCMDARG,
+  "Whether log archiving is desired (innodb_lsn_archived>0 if enabled)",
+  nullptr, innodb_log_archive_update, FALSE);
+
 static MYSQL_SYSVAR_UINT64_T(log_recovery_start, recv_sys.recovery_start,
   PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_READONLY,
   "checkpoint LSN to start recovery from (0=automatic)",
@@ -19442,7 +19471,7 @@ static MYSQL_SYSVAR_UINT64_T(log_recovery_target, recv_sys.rpo,
 
 static MYSQL_SYSVAR_ULONGLONG(log_file_size, srv_log_file_size,
   PLUGIN_VAR_RQCMDARG,
-  "Redo log size in bytes.",
+  "Desired size of ib_logfile0 in bytes",
   nullptr, innodb_log_file_size_update,
   96 << 20, 4 << 20, std::numeric_limits<ulonglong>::max(), 4096);
 
@@ -19874,6 +19903,7 @@ static struct st_mysql_sys_var* innobase_system_variables[]= {
   MYSQL_SYSVAR(log_file_write_through),
   MYSQL_SYSVAR(data_file_buffering),
   MYSQL_SYSVAR(data_file_write_through),
+  MYSQL_SYSVAR(log_archive),
   MYSQL_SYSVAR(log_recovery_start),
   MYSQL_SYSVAR(log_recovery_target),
   MYSQL_SYSVAR(log_file_size),

storage/innobase/include/log0log.h

@@ -247,13 +247,16 @@ struct log_t
   lsn_t (*writer)() noexcept;
   /** next checkpoint LSN (protected by latch.wr_lock()) */
   lsn_t next_checkpoint_lsn;
+  /** start of archived log, or 0 (proteted by latch.wr_lock()) */
+  lsn_t archived_lsn;
 
   /** Log file */
   log_file_t log;
 private:
   /** Log file being constructed during resizing; protected by latch */
   log_file_t resize_log;
-  /** size of resize_log; protected by latch */
+  /** size of resize_log, or the requested innodb_log_file_size
+  of the next file created if archive==TRUE; protected by latch */
   lsn_t resize_target;
   /** Buffer for writing to resize_log; @see buf */
   byte *resize_buf;
@@ -270,6 +273,8 @@ struct log_t
   uint write_size;
   /** format of the redo log: e.g., FORMAT_10_8 */
   uint32_t format;
+  /** the current value of innodb_log_archive; protected by latch.wr_lock() */
+  my_bool archive;
   /** whether the memory-mapped interface is enabled for the log */
   my_bool log_mmap;
   /** the default value of log_mmap */
@@ -455,8 +460,19 @@ struct log_t
   /** Persist the log.
   @param lsn            desired new value of flushed_to_disk_lsn */
   void persist(lsn_t lsn) noexcept;
+  /** Create, allocate and map a new log file. */
+  ATTRIBUTE_COLD void archive_new_mmap() noexcept;
 #endif
 
+  /** Ensure that innodb_log_archive=ON will default to the current
+  innodb_log_file_size if no size has been specified. */
+  void archive_set_size() noexcept
+  {
+    ut_ad(!resize_in_progress());
+    if (!resize_target)
+      resize_target= file_size;
+  }
+
   bool check_for_checkpoint() const
   {
     return UNIV_UNLIKELY(need_checkpoint.load(std::memory_order_relaxed));

storage/innobase/include/mtr0mtr.h

@@ -701,12 +701,22 @@ struct mtr_t {
   @return {start_lsn,flush_ahead_lsn} */
   std::pair<lsn_t,lsn_t> do_write() noexcept;
 
+  /** How to write log */
+  enum finish_writing {
+    /** circular memory-mapped writing when log_sys.is_mmap() */
+    CIRCULAR_MMAP,
+    /** memory-mapped log for log_sys.archive */
+    ARCHIVED_MMAP,
+    /** normal writing !log_sys.is_mmap() */
+    WRITE_NORMAL
+  };
+
   /** Append the redo log records to the redo log buffer.
-  @tparam mmap log_sys.is_mmap()
+  @tparam how  how to write
   @param mtr   mini-transaction
   @param len   number of bytes to write
   @return {start_lsn,flush_ahead_lsn} */
-  template<bool mmap> static
+  template<finish_writing how> static
   std::pair<lsn_t,lsn_t> finish_writer(mtr_t *mtr, size_t len);
 
   /** The applicable variant of commit_log() */