enabling sockets on 0.4.6

[drc38]

How do you enable sockets for testing in the latest version? I have tried adding the following to conftest.py:

from pytest_socket import enable_socket

def pytest_runtest_setup():
    """Enable socket for tests - default is to disable."""
    enable_socket()

and the following in the test function:

async def test_cms_responses(hass, socket_enabled):

but still get pytest_socket.SocketConnectBlockedError: raised when the test runs.

[MatthewFlamm]

I'm not very familiar but have you tried the built in fixture?

pytest-homeassistant-custom-component/pytest_homeassistant_custom_component/plugins.py

Line 96 in 47521e5

def socket_enabled(pytestconfig):

[drc38]

I'm not very familiar but have you tried the built in fixture?

pytest-homeassistant-custom-component/pytest_homeassistant_custom_component/plugins.py

Line 96 in 47521e5

def socket_enabled(pytestconfig):

How do you use the fixture in a test function or conftest.py, I tried passing socket_enabled to the function as per the example above but that didn't work.

[MatthewFlamm]

How do you use the fixture in a test function or conftest.py, I tried passing socket_enabled to the function as per the example above but that didn't work.

Like you did in your original comment. I'm not sure how the socket functionality works, but if you figure it out, we can put in a pointer here.

[MatthewFlamm]

All the examples in the core repo look something like this:

https://github.com/home-assistant/core/blob/4746ff379823fe552cb241a5fa65ebb59cdc20f3/tests/components/motioneye/test_camera.py#L66

[drc38]

I have not had any luck with resolving, this suggests it may be related to the fixture resolution order:
miketheman/pytest-socket#45

and a similar issue reported here:
miketheman/pytest-socket#57

[drc38]

Does having pytest_runtest_setup in the plugin override or prevent enable_socket being set by the local test function setup?

[MatthewFlamm]

I believe that the default behavior in the plugins here is to allow only host 127.0.0.1. Have you verified that it isn't failing because of trying to reach another host?

[drc38]

Thanks, I managed to get it working by changing all localhost references explicitly to 127.0.0.1 and using the socket_enabled marker. In my view the plug-in code should also explicitly allow ::1 which is equivalent to 127.0.0.1 and was referenced in the error message as a blocked address.

[MatthewFlamm]

In my view the plug-in code should also explicitly allow ::1 which is equivalent to 127.0.0.1 and was referenced in the error message as a blocked address.

I'm going to close this, since it seems you have an issue with either pytest-socket or the implementation thereof in home-assistant/core. The plugins here are taken directly from home-assistant/core with only minimal changes needed for custom components. These minimal changes are mainly due to file path changes when testing directly in core vs. as a custom component.