Skip to content

Commit 44eb5e1

Browse files
liubiingregkh
authored andcommitted
Revert "usb: musb: host: don't start next rx urb if current one failed"
This reverts commit dbac5d0. commit dbac5d0 ("usb: musb: host: don't start next rx urb if current one failed") along with commit b580121 ("usb: musb: host: clear rxcsr error bit if set") try to solve the issue described in [1], but the latter alone is sufficient, and the former causes the issue as in [2], so now revert it. [1] https://marc.info/?l=linux-usb&m=146173995117456&w=2 [2] https://marc.info/?l=linux-usb&m=151689238420622&w=2 Cc: [email protected] # v4.7+ Signed-off-by: Bin Liu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 17539f2 commit 44eb5e1

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

drivers/usb/musb/musb_host.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -391,13 +391,7 @@ static void musb_advance_schedule(struct musb *musb, struct urb *urb,
391391
}
392392
}
393393

394-
/*
395-
* The pipe must be broken if current urb->status is set, so don't
396-
* start next urb.
397-
* TODO: to minimize the risk of regression, only check urb->status
398-
* for RX, until we have a test case to understand the behavior of TX.
399-
*/
400-
if ((!status || !is_in) && qh && qh->is_ready) {
394+
if (qh != NULL && qh->is_ready) {
401395
musb_dbg(musb, "... next ep%d %cX urb %p",
402396
hw_ep->epnum, is_in ? 'R' : 'T', next_urb(qh));
403397
musb_start_urb(musb, is_in, qh);

0 commit comments

Comments
 (0)