Skip to content

Commit 61c6557

Browse files
usiemsmrbean-bremen
authored andcommitted
Rename "after-version" attribute to "since-version"
since that better matches the actual behavior
1 parent c0dcb99 commit 61c6557

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

generator/typesystem.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ void Handler::fetchAttributeValues(const QString &name, const QXmlAttributes &at
269269
QString key = atts.localName(i).toLower();
270270
QString val = atts.value(i);
271271

272-
if (!acceptedAttributes->contains(key) && key != "after-version" && key != "before-version") {
272+
if (!acceptedAttributes->contains(key) && key != "since-version" && key != "before-version") {
273273
ReportHandler::warning(QString("Unknown attribute for '%1': '%2'").arg(name).arg(key));
274274
} else {
275275
(*acceptedAttributes)[key] = val;
@@ -484,16 +484,16 @@ bool Handler::qtVersionMatches(const QXmlAttributes& atts, bool& ok)
484484
m_error = "Invalid 'before-version' version string: " + atts.value(beforeIndex);
485485
}
486486
}
487-
int afterIndex = atts.index("after-version"); // after-version really means this version or any version after
488-
if (afterIndex >= 0) {
489-
uint afterVersion = TypeSystem::qtVersionFromString(atts.value(afterIndex), ok);
487+
int sinceIndex = atts.index("since-version");
488+
if (sinceIndex >= 0) {
489+
uint sinceVersion = TypeSystem::qtVersionFromString(atts.value(sinceIndex), ok);
490490
if (ok) {
491-
if (m_qtVersion < afterVersion) {
491+
if (m_qtVersion < sinceVersion) {
492492
return false;
493493
}
494494
}
495495
else {
496-
m_error = "Invalid 'after-version' version string: " + atts.value(afterIndex);
496+
m_error = "Invalid 'since-version' version string: " + atts.value(sinceIndex);
497497
}
498498
}
499499
return true;

generator/typesystem_core.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1285,7 +1285,7 @@
12851285
<!-- Can't provide same API and performance -->
12861286

12871287
<modify-function signature="open(int,QFlags&lt;QIODevice::OpenModeFlag&gt;)" remove="all" before-version="6"/>
1288-
<modify-function signature="open(int,QFlags&lt;QIODeviceBase::OpenModeFlag&gt;,QFlags&lt;QFileDevice::FileHandleFlag&gt;)" remove="all" after-version="6"/>
1288+
<modify-function signature="open(int,QFlags&lt;QIODeviceBase::OpenModeFlag&gt;,QFlags&lt;QFileDevice::FileHandleFlag&gt;)" remove="all" since-version="6"/>
12891289
<modify-function signature="decodeName(const char*)" remove="all"/>
12901290
<modify-function signature="map(qint64,qint64,QFile::MemoryMapFlags)" remove="all"/>
12911291
<modify-function signature="unmap(uchar*)" remove="all"/>

generator/typesystem_multimedia.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
<enum-type name="QMediaStreamsControl::StreamType"/>
7676

7777
<namespace-type name="QAudio"/>
78-
<namespace-type name="QMultimedia" after-version="5"/>
78+
<namespace-type name="QMultimedia" since-version="5"/>
7979

8080
<object-type name="QAbstractVideoBuffer"/>
8181
<object-type name="QAbstractVideoSurface"/>
@@ -176,7 +176,7 @@
176176

177177
<object-type name="QMediaServiceProviderPlugin"/>
178178

179-
<group after-verson="6">
179+
<group since-version="6">
180180
<object-type name="QAudioDevice"/>
181181
<object-type name="QAudioSink"/>
182182
<object-type name="QAudioSource"/>

0 commit comments

Comments
 (0)