-
Notifications
You must be signed in to change notification settings - Fork 99
Parsing error during wrapper generation with Qt5.15 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Using code as of 77eba42 on Windows using MSVC tools such as "X64 Native Tools Command Prompt for VS 2022".
Then I built the pythonqt_generator project successfully and proceed to try running the generator:
Then upon reading #68 (comment) and running things from "/generator" as the working directory, I observed:
@usiems and @mrbean-bremen I have seen you two have been active in this repo recently. It appears I'm failing to complete wrapper generation successfully for Qt 5.15.2. Is this expected at this time using latest code in this repo? Can you help further debug here? It appears that the windows (win64_msvc2017_64, 3.6, x64, 5.11.*) job has similarly generated 0 items, so maybe things are just not working for Windows MSVC building? Those version of MSVC2017, Python 3.6 and Qt 5.11 are all different from my setup, but maybe things are in general broken on Windows? |
Yes, we have noticed that the MSVC build does not work in the CI both for Qt5 and Qt6, and this is something to be understood and fixed. We missed this until recently as the CI builds are still green (a check that files are generated should probably be added to avoid this). I'm locally working with VS 2022 and cmake, and this works fine for both Qt5 and Qt6, and I think @usiems also successfully used qmake. I'm quite sure that it also worked with Qt5.15 under VS 2019. I haven't used VS 2017 in a while, but there have been few relevant changes from 2017 to 2019. Having said this, there is a difference of how I call the generator - I do not set |
Seems like the problem is the environment variable |
hmm I'm still having issues (using cfb522b) with successful wrapper generation. I'm using Qt 5.15.2 downloaded for MSVC2019_x64 from the Qt Maintenance Tool and not built from source. I generally don't build from source due to many of the dependencies to build things such as Qt WebEngine which in Qt 5.15 I believe still required python 2.
@mrbean-bremen Is there something else I can check to determine if I have messed up somewhere either on the creation of the generator or the use of the generator? Could I be missing some other dependency? There is limited instructions at https://github.com/MeVisLab/pythonqt#building and I'm generally unfamiliar with qmake systems as I'm typically building code with libraries using cmake. https://github.com/MeVisLab/pythonqt/blob/cfb522be115f5ea265d62a6dfbfe9a7c3b420b87/generator/CMakeLists.txt appears to a bit outdated for Qt4. |
should the |
@iltommi Thanks! Of course one of those typos as a developer you overlook countless times 🤦🏻♂️ Here's my output now. @mrbean-bremen Take a look to confirm if this looks correct to you and if so close this issue as completed.
|
Yes, this looks good! The warnings don't look good of course, but most of them are irrelevant as they are related to removed methods. This is very similar to the output in the CI. We are thinking about changing that "feature" that the |
I made a PR that just does that (uses |
Closing as discussed. |
I tried to generate the wrapper with the generator with Qt5.15, but I encountered the following message:
After running it in debug, the culprit seems to be QXmlSimpleReader::parse in TypeDatabase::parseFile, which may work differently in Qt5.15 compared to previous versions.
The text was updated successfully, but these errors were encountered: