fix signal delivery with priority-ordering

Author: jkachmar

sdk/package.yaml

@@ -140,6 +140,7 @@ tests:
       - require-callstack
       - hs-opentelemetry-sdk
       - resourcet
+      - pqueue
     main: Main.hs
     source-dirs: test
     other-modules:

sdk/temporal-sdk.cabal

@@ -209,6 +209,7 @@ test-suite temporal-sdk-tests
     , monad-logger
     , mtl
     , network
+    , pqueue
     , proto-lens
     , proto-lens-protobuf-types
     , random

sdk/test/IntegrationSpec.hs

@@ -1505,8 +1505,6 @@ needsClient = do
                 signalWithArgs
                 1
 
-            -- liftIO $ threadDelay 1_000
-
             C.signal wfH signalWithArgs C.defaultSignalOptions 2
             lift $ C.waitWorkflowResult wfH `shouldReturn` [1, 2]
 

sdk/test/IntegrationSpec/Signals.hs

@@ -17,6 +17,7 @@ import Temporal.Duration
 import Temporal.Payload
 import Temporal.TH
 import Temporal.Workflow
+import qualified Data.PQueue.Prio.Min as MinPQueue
 
 
 unblockWorkflowSignal :: KnownSignal '[]
@@ -57,14 +58,15 @@ registerWorkflow 'signalWithArgsWorkflow
 
 signalEnqueuesItemWorkflow :: Workflow [Int]
 signalEnqueuesItemWorkflow = provideCallStack do
-  var <- newStateVar []
+  var <- newStateVar MinPQueue.empty
   setSignalHandler signalWithArgs $ \i -> do
     $(logDebug) "updating value and unblocking workflow"
-    readStateVar var >>= \s -> writeStateVar var (s <> [i])
+    t <- now
+    readStateVar var >>= \s -> writeStateVar var (MinPQueue.insert t i s)
 
   sleep (seconds 2)
 
-  waitCondition $ (not . null) <$> readStateVar var
-  readStateVar var
+  waitCondition $ (not . MinPQueue.null) <$> readStateVar var
+  (map snd . MinPQueue.toList) <$> readStateVar var
 
 registerWorkflow 'signalEnqueuesItemWorkflow