test: Add shared.ts tests

Author: rekmarks

constraints.pro

@@ -301,6 +301,7 @@ gen_enforced_field(WorkspaceCwd, 'scripts.changelog:update', CorrectChangelogUpd
 % All non-root packages must have the same "test" script.
 gen_enforced_field(WorkspaceCwd, 'scripts.test', 'jest --reporters=jest-silent-reporter') :-
   WorkspaceCwd \= 'packages/extension',
+  WorkspaceCwd \= 'packages/shims',
   WorkspaceCwd \= '.'.
 
 % All non-root packages must have the same "test:clean" script.

packages/extension/src/shared.test.ts

@@ -0,0 +1,64 @@
+import { vi, describe, it, expect } from 'vitest';
+
+import { isWrappedIframeMessage, makeHandledCallback } from './shared';
+
+describe('shared', () => {
+  describe('isWrappedIframeMessage', () => {
+    it('returns true for valid messages', () => {
+      expect(
+        isWrappedIframeMessage({
+          id: '1',
+          message: { type: 'evaluate', data: '1 + 1' },
+        }),
+      ).toBe(true);
+    });
+
+    it('returns false for invalid messages', () => {
+      const invalidMessages = [
+        {},
+        { id: '1' },
+        { message: { type: 'evaluate' } },
+        { id: '1', message: { type: 'evaluate' } },
+        { id: '1', message: { type: 'evaluate', data: 1 } },
+      ];
+
+      invalidMessages.forEach((message) => {
+        expect(isWrappedIframeMessage(message)).toBe(false);
+      });
+    });
+  });
+
+  describe('makeHandledCallback', () => {
+    it('returns a function', () => {
+      const callback = makeHandledCallback(async () => Promise.resolve());
+      expect(callback).toBeInstanceOf(Function);
+    });
+
+    it('calls the original callback', () => {
+      const originalCallback = vi.fn().mockResolvedValueOnce(undefined);
+      const callback = makeHandledCallback(originalCallback);
+
+      // eslint-disable-next-line n/callback-return
+      callback();
+
+      expect(originalCallback).toHaveBeenCalledOnce();
+    });
+
+    it('throws an error if the original callback throws an error', async () => {
+      const consoleErrorSpy = vi.spyOn(console, 'error');
+      const error = new Error('test error');
+      const originalCallback = vi.fn().mockRejectedValueOnce(error);
+      const callback = makeHandledCallback(originalCallback);
+
+      // eslint-disable-next-line n/callback-return
+      callback();
+      // eslint-disable-next-line @typescript-eslint/await-thenable
+      await null;
+
+      expect(consoleErrorSpy).toHaveBeenCalledOnce();
+      expect(consoleErrorSpy).toHaveBeenCalledWith(
+        expect.objectContaining({ message: error.message }),
+      );
+    });
+  });
+});

packages/extension/src/shared.ts

@@ -46,8 +46,6 @@ export const makeHandledCallback = <Args extends unknown[]>(
 ) => {
   return (...args: Args): void => {
     // eslint-disable-next-line n/no-callback-literal, n/callback-return
-    callback(...args).catch((error: Error) => {
-      throw error;
-    });
+    callback(...args).catch(console.error);
   };
 };

packages/shims/package.json

@@ -25,7 +25,7 @@
     "changelog:validate": "../../scripts/validate-changelog.sh @ocap/shims",
     "clean": "rimraf ./dist",
     "publish:preview": "yarn npm publish --tag preview",
-    "test": "jest --reporters=jest-silent-reporter",
+    "test": "jest --reporters=jest-silent-reporter --passWithNoTests",
     "test:clean": "jest --clearCache",
     "test:dev": "jest --verbose --coverage false",
     "test:verbose": "jest --verbose",