Skip to content

Commit 028f616

Browse files
committed
Remove warning from github eval fetching
1 parent 68a3cb7 commit 028f616

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

nixpkgs_review/github.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from pathlib import Path
1010
from typing import IO, Any, override
1111

12-
from .utils import System, warn
12+
from .utils import System
1313

1414

1515
def pr_url(pr: int) -> str:
@@ -175,19 +175,14 @@ def get_github_action_eval_result(
175175
workflow_run["artifacts_url"],
176176
)["artifacts"]
177177

178-
found_comparison = False
179178
for artifact in artifacts:
180179
if artifact["name"] != "comparison":
181180
continue
182-
found_comparison = True
183181
changed_paths: Any = self.get_json_from_artifact(
184182
workflow_id=artifact["id"],
185183
json_filename="changed-paths.json",
186184
)
187185
if changed_paths is None:
188-
warn(
189-
f"Found comparison artifact, but no changed-paths.json in workflow {workflow_run['html_url']}"
190-
)
191186
continue
192187
if (path := changed_paths.get("rebuildsByPlatform")) is not None:
193188
assert isinstance(path, dict)
@@ -197,14 +192,4 @@ def get_github_action_eval_result(
197192
for system, packages_list in path.items()
198193
}
199194

200-
if not found_comparison:
201-
if workflow_run["status"] == "queued":
202-
warn(
203-
f"Found eval workflow run, but evaluation is still work in progress: {workflow_run['html_url']}"
204-
)
205-
else:
206-
warn(
207-
f"Found eval workflow run, but no comparison artifact in {workflow_run['html_url']}."
208-
)
209-
210195
return None

0 commit comments

Comments
 (0)