Skip to content

Commit 23f9219

Browse files
authored
Merge pull request #442 from lucasew/20241224-no-headers
pr: add flag --no-headers
2 parents eb4f1b1 + ad49edb commit 23f9219

File tree

4 files changed

+24
-11
lines changed

4 files changed

+24
-11
lines changed

nixpkgs_review/cli/__init__.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@ def pr_flags(
6666
action="store_true",
6767
help="Post the nixpkgs-review results as a PR comment",
6868
)
69+
pr_parser.add_argument(
70+
"--no-headers",
71+
action="store_true",
72+
help="Do not render the header in the markdown report",
73+
)
6974
pr_parser.set_defaults(func=pr_command)
7075
return pr_parser
7176

nixpkgs_review/cli/pr.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ def pr_command(args: argparse.Namespace) -> str:
9393
nixpkgs_config=nixpkgs_config,
9494
extra_nixpkgs_config=args.extra_nixpkgs_config,
9595
num_parallel_evals=args.num_parallel_evals,
96+
show_header=not args.no_headers,
9697
)
9798
contexts.append((pr, builddir.path, review.build_pr(pr)))
9899
except NixpkgsReviewError as e:

nixpkgs_review/report.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,11 @@ def __init__(
149149
self,
150150
attrs_per_system: dict[str, list[Attr]],
151151
extra_nixpkgs_config: str,
152+
show_header: bool = True,
152153
*,
153154
checkout: Literal["merge", "commit"] = "merge",
154155
) -> None:
156+
self.show_header = show_header
155157
self.attrs = attrs_per_system
156158
self.checkout = checkout
157159

@@ -198,17 +200,19 @@ def json(self, pr: int | None) -> str:
198200
)
199201

200202
def markdown(self, pr: int | None) -> str:
201-
msg = "## `nixpkgs-review` result\n\n"
202-
msg += "Generated using [`nixpkgs-review`](https://github.com/Mic92/nixpkgs-review).\n\n"
203-
204-
cmd = "nixpkgs-review"
205-
if pr is not None:
206-
cmd += f" pr {pr}"
207-
if self.extra_nixpkgs_config:
208-
cmd += f" --extra-nixpkgs-config '{self.extra_nixpkgs_config}'"
209-
if self.checkout != "merge":
210-
cmd += f" --checkout {self.checkout}"
211-
msg += f"Command: `{cmd}`\n"
203+
msg = ""
204+
if self.show_header:
205+
msg += "## `nixpkgs-review` result\n\n"
206+
msg += "Generated using [`nixpkgs-review`](https://github.com/Mic92/nixpkgs-review).\n\n"
207+
208+
cmd = "nixpkgs-review"
209+
if pr is not None:
210+
cmd += f" pr {pr}"
211+
if self.extra_nixpkgs_config:
212+
cmd += f" --extra-nixpkgs-config '{self.extra_nixpkgs_config}'"
213+
if self.checkout != "merge":
214+
cmd += f" --checkout {self.checkout}"
215+
msg += f"Command: `{cmd}`\n"
212216

213217
for system, report in self.system_reports.items():
214218
msg += "\n---\n"

nixpkgs_review/review.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ def __init__(
106106
checkout: CheckoutOption = CheckoutOption.MERGE,
107107
sandbox: bool = False,
108108
num_parallel_evals: int = 1,
109+
show_header: bool = True,
109110
) -> None:
110111
if skip_packages_regex is None:
111112
skip_packages_regex = []
@@ -144,6 +145,7 @@ def __init__(
144145
self.nixpkgs_config = nixpkgs_config
145146
self.extra_nixpkgs_config = extra_nixpkgs_config
146147
self.num_parallel_evals = num_parallel_evals
148+
self.show_header = show_header
147149

148150
def _process_aliases_for_systems(self, system: str) -> set[str]:
149151
match system:
@@ -359,6 +361,7 @@ def start_review(
359361
attrs_per_system,
360362
self.extra_nixpkgs_config,
361363
checkout=self.checkout.name.lower(), # type: ignore[arg-type]
364+
show_header=self.show_header,
362365
)
363366
report.print_console(pr)
364367
report.write(path, pr)

0 commit comments

Comments
 (0)