Namespaces changed between 2.4.0 and 2.5.0

[xt0rted]

I reported this in the webjobs sdk repo (Azure/azure-webjobs-sdk#1619), but I wanted to bring it up here too. Between versions 2.4.0 and 2.5.0 the SamplingPercentageEstimatorSettings class, which the webjobs AI logger uses, moved to a new namespace (I'm sure there's many other classes that did as well).

• 2.4.0 SamplingPercentageEstimatorSettings.cs
• 2.5.0 SamplingPercentageEstimatorSettings.cs

Because of this change if you try to use version 2.1.0 of the webjobs sdk with AI 2.5.0+ it'll compile, but crash when the AI logger starts up.

[TimothyMothra]

Sorry for the inconvenience.
There had been some shuffling around, but it wasn't supposed to affect anything public.
Give me a couple days to look into this.
Thank you for linking the specific files, that will help my investigation.

[pharring]

I thought we had the public API checker analyzer to avoid this sort of thing. Or perhaps it wasn't added until later.

[TimothyMothra]

@pharring we do have a checker and I think the expectation is that this should have been caught.

[SergeyKanzhelev]

Checker was added after the change I believe Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: MS-TimothyMothra <notifications@github.com> Sent: Thursday, March 8, 2018 11:39:44 AM To: Microsoft/ApplicationInsights-dotnet Cc: Subscribed Subject: Re: [Microsoft/ApplicationInsights-dotnet] Namespaces changed between 2.4.0 and 2.5.0 (#727) @pharring<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpharring&data=04%7C01%7CSergey.Kanzhelev%40microsoft.com%7Ce4be93d93173459e308108d5852c58d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636561347871743951%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=bvjjk7xUPMlRelP6REW1%2BqNmxV6%2B0JeZZOsaVN9HA0Q%3D&reserved=0> we do have a checker and I think the expectation is that this should have been caught. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FApplicationInsights-dotnet%2Fissues%2F727%23issuecomment-371599931&data=04%7C01%7CSergey.Kanzhelev%40microsoft.com%7Ce4be93d93173459e308108d5852c58d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636561347871753972%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=cKSeWrX%2FnF9brHdJJP5y0nLljmBUkz%2Bq7yMnELeIZys%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJfTgVKw85iSA59qO67A5rS5KIwcVh5hks5tcYkAgaJpZM4SiLSm&data=04%7C01%7CSergey.Kanzhelev%40microsoft.com%7Ce4be93d93173459e308108d5852c58d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636561347871753972%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=auLlKPEcADDp%2Fxl48rCoJJDOt06hmW39MQAGOz3s6Y8%3D&reserved=0>.

[julKali]

Hi, do you know any date when this will be fixed?

[TimothyMothra]

Sorry for the delay, finally getting back to this...

Looks like this changed happened on 2017-11-20 as a part of PR #656.

SamplingPercentageEstimatorSettings's namespace was changed

• from: Microsoft.ApplicationInsights.WindowsServer.Channel.Implementation.
• to: Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.Implementation

(Channel -> TelemetryChannel)

This class is in the "TelemetryChannel" directory, so this change isn't incorrect... but because it's a public class it has affected some customers (see link above).

---

@SergeyKanzhelev, would it be better to revert this change, or should we reach out to webjobs and ask them to update? Who would we contact to discuss with them?

[SergeyKanzhelev]

Do we have stable version of SDK with those classes moved already? If so - we would need to add classes into older SDK which are basically a proxies to the ones in new namespaces. If it was released in -beta it would be correct to revert the change back. Just follow the semver rules

[xt0rted]

Based on what I found while tracking this down the change happened prior to releasing AI 2.5.0 so the webjobs team needs to update their package, release a new major or minor version with the AI dependency set to >= 2.5.0, and then do a patch release of the effected version that locks the AI version to < 2.5.0.

[TimothyMothra]

@xt0rted We're going to take ownership and fix it on our end.
We're planning to release 2.6.0 in the first half of May so this makes sense to fix with that.